Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebeat, heartbeat, packetbeat: remove python #201310

Closed
wants to merge 3 commits into from
Closed

filebeat, heartbeat, packetbeat: remove python #201310

wants to merge 3 commits into from

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Seeing if #201219 is applicable to other beats

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Dec 16, 2024
@branchvincent branchvincent added the CI-no-bottles Merge without publishing bottles label Dec 16, 2024
@branchvincent branchvincent force-pushed the filebeat branch 2 times, most recently from c7ba864 to 9cd41e5 Compare December 16, 2024 02:14
@cho-m
Copy link
Member

cho-m commented Dec 16, 2024 •
edited
Loading

Python gets used if docs are built. In some of the *beat formulae, they were inreplaced out since they aren't installed (and build may fail from deleting non-OSS code).

filebeat partly removes docs, but may still be generating some via filebeat.CollectDocs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jan 6, 2025
@github-actions github-actions bot closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@branchvincent @cho-m