Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-6654: Combine walk and wait cards #5231

Merged
merged 7 commits into from
Jan 23, 2025
Merged

DT-6654: Combine walk and wait cards #5231

merged 7 commits into from
Jan 23, 2025
+243 −91

Conversation

Antiik91
Copy link
Member

Proposed Changes

  • Walk to a stop now has walk instructions, as well as information about the vehicle you are boarding.
  • Expand icon has now two seperate sizes depending on where it is used. (16px * 16px & 24px * 24px)

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

vesameskanen
vesameskanen requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@vesameskanen vesameskanen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use a bit more modular approach here, instead of copypasting jsx snippets and styles around. Route information appears identical both in MOVE extension and WAIT card. Transit extension also shows similar route icon with headsign.

Styling of such shared elements should also happen in a shared manner, instead of repeating the applied style class as a new nested sub style.

https://files.slack.com/files-pri/T03HA371Q-F088Q5ZKCQ7/image.png?is_viewed=1

app/component/itinerary/navigator/NaviCardExtension.js Outdated Show resolved Hide resolved
app/component/itinerary/navigator/NaviCardExtension.js Outdated Show resolved Hide resolved
@vesameskanen vesameskanen merged commit df513e6 into v3 Jan 23, 2025
6 checks passed
@vesameskanen vesameskanen deleted the DT-6654 branch January 23, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vesameskanen vesameskanen vesameskanen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antiik91 @vesameskanen