Skip to content
This repository has been archived by the owner on Sep 15, 2024. It is now read-only.

fix: Yidadaa#3241 should not ensure openai url non-empty #88

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: Yidadaa#3241 should not ensure openai url non-empty #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
632ad35
Merge pull request #3233 from nanaya-tachibana/nanaya/model-selection
Yidadaa Nov 13, 2023
eaa981b
fix: #3241 should not ensure openai url non-empty
Yidadaa Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/components/model-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ export function ModelConfigList(props: {
);
}}
>
{allModels.map((v, i) => (
<option value={v.name} key={i} disabled={!v.available}>
{v.name}
</option>
))}
{allModels
.filter((v) => v.available)
.map((v, i) => (
<option value={v.name} key={i}>
{v.displayName}
</option>
))}
</Select>
</ListItem>
{isDalleModel && (
Expand Down
2 changes: 1 addition & 1 deletion app/store/access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const useAccessStore = createPersistStore(
},

isValidOpenAI() {
return ensure(get(), ["openaiUrl", "openaiApiKey"]);
return ensure(get(), ["openaiApiKey"]);
},

isValidAzure() {
Expand Down