Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce runtime dependencies #691

Closed
wants to merge 1 commit into from

Conversation

CallanMcNulty
Copy link
Contributor

Runtime dependency count is decently low already, but a few more can be cut out with minimal changes.

@Grsmto
Copy link
Owner

Grsmto commented Jun 13, 2024

Hi! I completely missed that and actually did exactly this a few minutes ago myself!
Maybe I saw your PR and did it unconsciously...

Anyway, thanks a lot for your contribution and sorry to not merge this!

@Grsmto Grsmto closed this Jun 13, 2024
@CallanMcNulty
Copy link
Contributor Author

Hi! I completely missed that and actually did exactly this a few minutes ago myself! Maybe I saw your PR and did it unconsciously...

Anyway, thanks a lot for your contribution and sorry to not merge this!

I see you removed can-use-dom from simplebar-core. Glad to see that. There are a few things this PR was doing that didn't get implemented though, so I opened another PR to handle the remaining stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants