Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(rfcs): Add table engine refactor RFC #1899

Merged
merged 4 commits into from
Jul 7, 2023
Merged

docs(rfcs): Add table engine refactor RFC #1899

merged 4 commits into from
Jul 7, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Jul 6, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

RFC for refactoring table engine to region engine

Rendered

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag mentioned this pull request Jul 6, 2023
Closed
40 tasks
@evenyag evenyag force-pushed the docs/table-engine-refactor branch 3 times, most recently from 78d33b3 to 858dcee Compare July 7, 2023 04:41
@evenyag evenyag marked this pull request as ready for review July 7, 2023 04:42
@evenyag evenyag requested review from v0y4g3r and waynexia July 7, 2023 04:53
@evenyag
Copy link
Contributor Author

evenyag commented Jul 7, 2023

Wait for #1902

@evenyag evenyag force-pushed the docs/table-engine-refactor branch from 858dcee to aa8e89d Compare July 7, 2023 06:34
v0y4g3r
v0y4g3r approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mermaid diagrams are awesome 👀

killme2008
killme2008 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@killme2008 killme2008 merged commit 55500b7 into GreptimeTeam:develop Jul 7, 2023
@evenyag evenyag mentioned this pull request Jul 7, 2023
Merged
2 tasks
@evenyag evenyag self-assigned this Jul 10, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@evenyag @v0y4g3r @paomian
docs(rfcs): Add table engine refactor RFC (GreptimeTeam#1899)
78da614 
* docs(rfcs): Add table engine refactor RFC

* docs(rfcs): add pics

* refactor: replace svg files with mermaid diagrams

---------

Co-authored-by: Lei, HUANG <mrsatangel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v0y4g3r v0y4g3r v0y4g3r approved these changes

@killme2008 killme2008 killme2008 approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees

@evenyag evenyag

Labels
None yet
Projects
mito2
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evenyag @killme2008 @v0y4g3r