Fix acceptance test failures caused by HostAuthorization in Sinatra 4.10 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1.0 The acceptance tests failed because Sinatra 4.1.0 introduced `HostAuthorization` sinatra/sinatra#2053, which rejects connections from remote hosts by default unless explicitly allowed. This behavior affects environments where the app is accessed from remote addresses during tests. Setting `APP_ENV` to `production` fixes that, allowing the tests to pass without further configuration. Updated the environment setup to include this fix.
Updated to use `docker compose`, the newer and recommended way of managing multi-container Docker applications, replacing the deprecated `docker-compose` command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acceptance tests failed because Sinatra 4.1.0 introduced
HostAuthorizationsinatra/sinatra#2053, which rejects connections from remote hosts by default unless explicitly allowed. This behavior affects environments where the app is accessed from remote addresses during tests.Setting
APP_ENVtoproductionfixes that, allowing the tests to pass without further configuration. Updated the environment setup to include this fix.Link to Jira card (if applicable):
https://technologyprogramme.atlassian.net/browse/GW-2053