Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates to Check-Spelling Configuration #702

Merged
merged 33 commits into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1b5db51
chore: Fix check-spelling false positive
holtskinner May 22, 2024
ad6a38b
Updates to check-spelling config
holtskinner May 22, 2024
71732ab
Formatting
holtskinner May 22, 2024
23da4d5
Remove ipynb exclude
holtskinner May 22, 2024
57f6a87
Add ignore for metadata id and added expected patterns
holtskinner May 22, 2024
7a9c00f
Add base64 ignore
holtskinner May 22, 2024
1150876
Add additional words/patterns
holtskinner May 22, 2024
03deb76
Fix forbidden patterns
holtskinner May 22, 2024
2673b51
Add more ignores
holtskinner May 22, 2024
dd50902
Add spelling configs
holtskinner May 22, 2024
5d1d53b
Fix spelling errors
holtskinner May 22, 2024
74026e7
Add additional dictionaries
holtskinner May 22, 2024
efbff08
Add more patterns
holtskinner May 22, 2024
699722c
Add spelling fixes
holtskinner May 22, 2024
ceccf95
Added extra patterns
holtskinner May 22, 2024
d37924e
Fix spelling errors
holtskinner May 22, 2024
db33cb7
Update patterns
holtskinner May 22, 2024
69ad8eb
More fixes
holtskinner May 22, 2024
dd7feb0
Update patterns
holtskinner May 22, 2024
574205a
New patterns
holtskinner May 22, 2024
2a288c2
Update patterns and errors
holtskinner May 22, 2024
c8b0563
Add google dict
holtskinner May 23, 2024
d2c8eea
Update patterns
holtskinner May 23, 2024
f098910
Fix errors
holtskinner May 23, 2024
fb865b5
Merge branch 'main' into spelling-updates
holtskinner May 23, 2024
8bc4aa6
Add dictionaries
holtskinner May 23, 2024
55e5cd0
Spelling fixes
holtskinner May 23, 2024
88e905b
Merge branch 'spelling-updates' of https://github.com/GoogleCloudPlat…
holtskinner May 23, 2024
1b5e485
Update base64 pattern
holtskinner May 23, 2024
02d3e1d
Fix spelling errors
holtskinner May 23, 2024
ad1527d
[check-spelling] Update metadata
holtskinner May 23, 2024
4abc867
Fix error
holtskinner May 23, 2024
237d5c3
Add check for changed files
holtskinner May 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/actions/spelling/advice.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<details><summary>If the flagged items are :exploding_head: false positives</summary>

If items relate to a ...

* binary file (or some other file you wouldn't want to check at all).

Please add a file path to the `excludes.txt` file matching the containing file.
Expand All @@ -14,9 +15,7 @@ https://www.regexplanet.com/advanced/perl/) yours before committing to verify it

* well-formed pattern.

If you can write a [pattern](
https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns
) that would match it,
If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it,
try adding it to the `patterns.txt` file.

Patterns are Perl 5 Regular Expressions - you can [test](
Expand Down
3 changes: 3 additions & 0 deletions .github/actions/spelling/candidate.patterns
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,8 @@ PrependWithABINamepsace
>[-a-zA-Z=;:/0-9+]{3,}=</
# base64 encoded content, possibly wrapped in mime
#(?:^|[\s=;:?])[-a-zA-Z=;:/0-9+]{50,}(?:[\s=;:?]|$)
# base64 in notebooks
base64,[A-Za-z0-9+\/=]{20,}

# encoded-word
=\?[-a-zA-Z0-9"*%]+\?[BQ]\?[^?]{0,75}\?=
Expand Down Expand Up @@ -682,3 +684,4 @@ W/"[^"]+"
/var/folders/\w\w/[+\w]+/(?:T|-Caches-)/
# github runner temp folders
/home/runner/work/_temp/[-_/a-z0-9]+

20 changes: 16 additions & 4 deletions .github/actions/spelling/excludes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
(?:^|/)(?i)COPYRIGHT
(?:^|/)(?i)LICEN[CS]E
(?:^|/)3rdparty/
(?:^|/)chain_of_thought_react\.ipynb$
(?:^|/)go\.sum$
(?:^|/)package(?:-lock|)\.json$
(?:^|/)Pipfile$
(?:^|/)pyproject.toml
(?:^|/)requirements(?:-dev|-doc|-test|)\.txt$
(?:^|/)vendor/
/CODEOWNERS$
\.a$
\.ai$
\.all-contributorsrc$
Expand Down Expand Up @@ -35,7 +37,6 @@
\.gz$
\.icns$
\.ico$
\.ipynb$
\.jar$
\.jks$
\.jpe?g$
Expand Down Expand Up @@ -79,12 +80,23 @@
\.xz$
\.zip$
^\.github/actions/spelling/
^\Q.github/workflows/spelling.yml\E$
^\Q.github/workflows/spelling.yaml\E$
^\Qgemini/function-calling/use_case_company_news_and_insights.ipynb\E$
^\Qgemini/getting-started/intro_gemini_1_5_pro.ipynb\E$
^\Qgemini/getting-started/intro_gemini_pro_vision_python.ipynb\E$
^\Qgemini/getting-started/intro_gemini_python.ipynb\E$
^\Qgemini/reasoning-engine/tutorial_google_maps_agent.ipynb\E$
^\Qgemini/sample-apps/image-bash-jam/images/.keep\E$
^\Qgemini/sample-apps/image-bash-jam/README.md\E$
^\Qgemini/use-cases/applying-llms-to-data/using-gemini-with-bigquery-remote-functions/src/sql/provision_text_sample_table.sql\E$
^\Qgemini/use-cases/healthcare/react_gemini_healthcare_api.ipynb\E$
^\Qgemini/use-cases/intro_multimodal_use_cases.ipynb\E$
^\Qgemini/use-cases/retrieval-augmented-generation/intro_multimodal_rag.ipynb\E$
^\Qlanguage/use-cases/document-qa/utils/__init__.py\E$
^\Qlanguage/use-cases/marketing-image-overlay/marketing_image_overlay.ipynb\E$
^\Qsearch/bulk-question-answering/bulk_question_answering_output.tsv\E$
^\Qvision/getting-started/image_editing_maskmode.ipynb\E$
^\Qvision/getting-started/image_generation.ipynb\E$
^\Qvision/getting-started/visual_captioning.ipynb\E$
^\Qvision/use-cases/creating_high_quality_visual_assets_with_gemini_and_imagen.ipynb\E$
ignore$
italian
/CODEOWNERS$
Loading
Loading