Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates to Check-Spelling Configuration #702

Merged
merged 33 commits into from
May 23, 2024
Merged

Conversation

holtskinner
Copy link
Collaborator

No description provided.

@holtskinner holtskinner requested review from a team and yil532 May 22, 2024 15:23
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@holtskinner
Copy link
Collaborator Author

@check-spelling-bot apply updates

Copy link

@check-spelling-bot: Could not perform request.

Apply failed.

/home/runner/work/_actions/check-spelling/check-spelling/prerelease/apply.pl: GitHub Run may not have completed. If so, please wait for it to finish and try again.

See log for details.

@holtskinner

This comment has been minimized.

Update for https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/9210774707/attempts/2
Accepted in #702 (comment)

Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com>
on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev>
Copy link

⌛ check-spelling changes applied

As configured, the commit pushed by @check-spelling-bot to GitHub doesn't trigger GitHub workflows due to a limitation of the @github-actions system.

Users with the Admin role can address this for future interactions 🪄

Create a deploy key and secret

(
  set -e
  brand=check-spelling; repo='GoogleCloudPlatform/generative-ai'; SECRET_NAME=CHECK_SPELLING
  cd "$(mktemp -d)"
  ssh-keygen -f "./$brand" -q -N "" -C "$brand key for $repo"
  gh repo deploy-key add "./$brand.pub" -R "$repo" -w -t "$brand-talk-to-bot"
  gh secret -R "$repo" set "$SECRET_NAME" < "./$brand"
)

Configure update job in workflow to use secret

If the .github/workflows/spelling.yaml workflow Update PR job doesn't already have the check-spelling/with/ssh_key, then add them:

    name: Update PR
    ...
    steps:
    ...
    - name: apply spelling updates
      uses: ${action_ref:-check-spelling/check-spelling@...}
      with:
        checkout: true
+       ssh_key: "${{ secrets.CHECK_SPELLING }}"

To trigger another validation round and hopefully a ✅, please add a blank line, e.g. to .github/actions/spelling/expect.txt and commit the change.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@holtskinner
Copy link
Collaborator Author

@check-spelling-bot apply updates.

Copy link

@check-spelling-bot: Could not perform request.

Request did not change repository content.

Maybe someone already applied these changes?

See log for details.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@holtskinner holtskinner merged commit 824b32b into main May 23, 2024
31 of 34 checks passed
@holtskinner holtskinner deleted the spelling-updates branch May 23, 2024 16:51
zeroasterisk pushed a commit to zeroasterisk/generative-ai that referenced this pull request Jul 4, 2024
Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com>
Co-authored-by: Holt Skinner <holtskinner@users.noreply.github.com>
skewalramani-oss pushed a commit to skewalramani-oss/generative-ai that referenced this pull request Aug 3, 2024
Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com>
Co-authored-by: Holt Skinner <holtskinner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant