Add support for v1beta1 device plugin API. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayingz
force-pushed
the
v1beta1
branch
3 times, most recently
from
c6035a7 to
ee03db1
Compare
vishh
reviewed
Feb 22, 2018
Makefile
Outdated
|
|
||
| build: | ||
| go install ${REPO}/pkg/gpu/nvidia |
Dockerfile
Outdated
| @@ -15,6 +15,7 @@ | |||
| FROM golang:1.9-alpine as builder | |||
| WORKDIR /go/src/github.com/GoogleCloudPlatform/container-engine-accelerators | |||
| COPY . . | |||
| RUN go install github.com/GoogleCloudPlatform/container-engine-accelerators/pkg/gpu/nvidia | |||
|
Fix the |
jiayingz
force-pushed
the
v1beta1
branch
3 times, most recently
from
f24568e to
7a0fe87
Compare
vishh
reviewed
Feb 22, 2018
pkg/gpu/nvidia/manager.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| hostPathPrefix = flag.String("host-path", "/home/kubernetes/bin/nvidia", "Path on the host that contains nvidia libraries. This will be mounted inside the container as '-container-path'") |
There was a problem hiding this comment.
nit: Flags should be in injected to libraries.
|
LGTM |
|
Thanks a lot for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than unit tests, also ran GPUDevicePlugin e2e test with and without PR kubernetes/kubernetes#58282 to make sure the gke gpu device plugin works with both v1alpha kubelet and v1beta1 kubelet.