pycsp: Implement Python binding for csp_sfp_send #15
Conversation
The documentation for `w*` specifies that > The caller have to call PyBuffer_Release() when it is done with the buffer. https://docs.python.org/3/c-api/arg.html
The `csp_sfp_send()` function is missing from the Python interface. Furthermore, it is impossible to otherwise implement in pure Python using the existing `pycsp` functions because: The `csp_sfp_send()` function sets `CSP_FFRAG` flag in each packet header before `csp_send()`. That flag cannot be set using`pycsp_connect` so it is in effect an internal flag.
jichgom
force-pushed
the
pycsp-sfp-send
branch
from
bac8ce3
to
09a375c
Compare
|
@Wramberg, hvad er det nu for en pseudo person |
|
Teamet skal stå som collaborator på repo ellers kan man ikke vælge det som reviewer |
|
@Wramberg, will anyone from products review this? |
|
I recently added bindings to I added those binding to libgscsp to avoid having this intermediate libcsp fork with minimal changes compared to upstream. I know we have stuff in GomSpace/libcsp already, but just wanted to avoid keep feeling up the fork. (I'd rather see it gone, with libgscsp only wrapping libcsp/libcsp). Any chance the new binding here can be implemented in libgscsp instead? |
The function sets internal flags on csp_conn_t that are not accessible in Python, making it hard to implement in Python.
There is also a commit included in this that implements freeing of
Py_Bufferin the bindings. Have a look at the commit message for more details