Update Kyrgyz locale information #1872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
commented
Oct 29, 2024
|
Hi @obulat The fix is much simpler, the following translation needs to be corrected back to "ky-KG": https://translate.wordpress.org/projects/wp/dev/kir/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=2379367&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc |
|
I have now updated the "translation" of "html_lang_attribute" for all active versions of WordPress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We discovered this problem when running the Lighthouse test on https://openverse.org: Incorrect slug for Kyrgyz locale.
slugandwp_localefor Kyrgyz locale are incorrect. This locale was last updated in Update Kyrgyz locale information, but the data used in it did not match the language editor's request.Locale object also did not have pluralization data.I removed it because the tests are failingSolution
This PR updates the locale object:
$kir$kgwp_localekirky_KGslugkirkyNotes
The locale list used in the Google LightHouse check (see that there is no
kirlocale in the list): https://github.com/dequelabs/axe-core/blob/e8eec734b3d32e5239fccab6645ce2ce51aa2e5e/lib/core/utils/valid-langs.jsThe pluralization rules: https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html
Data on Kyrgyz locale: https://www.localeplanet.com/icu/ky-KG/index.html