Skip to content

Commit

Permalink
Daemon: Remove preflight check from daemon command
Browse files Browse the repository at this point in the history
This PR remove preflight checks for daemon command because daemon can
run independent of a crc setup. the actual check happens when you
perform a `crc start`. Since those tests run as part of crc daemon which
takes around 5-6 sec so initial api response become block for 5-6 sec.
  • Loading branch information
praveenkumar committed Mar 31, 2022
1 parent 7e14cb3 commit 9c9d9ed
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions cmd/crc/cmd/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,13 @@ import (
"github.com/code-ready/crc/pkg/crc/constants"
"github.com/code-ready/crc/pkg/crc/daemonclient"
"github.com/code-ready/crc/pkg/crc/logging"
"github.com/code-ready/crc/pkg/crc/preflight"
"github.com/containers/gvisor-tap-vsock/pkg/types"
"github.com/containers/gvisor-tap-vsock/pkg/virtualnetwork"
"github.com/docker/go-units"
"github.com/gorilla/handlers"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"k8s.io/client-go/util/exec"
)

var watchdog bool
Expand Down Expand Up @@ -56,13 +54,6 @@ var daemonCmd = &cobra.Command{
return errors.New("daemon is already running")
}

if err := preflight.StartPreflightChecks(config); err != nil {
return exec.CodeExitError{
Err: err,
Code: preflightFailedExitCode,
}
}

virtualNetworkConfig := types.Configuration{
Debug: false, // never log packets
CaptureFile: os.Getenv("CRC_DAEMON_PCAP_FILE"),
Expand Down

0 comments on commit 9c9d9ed

Please sign in to comment.