Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT_7EYES-O-MATIC #59

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

GT_7EYES-O-MATIC #59

wants to merge 15 commits into from

Conversation

4Luke4
Copy link
Contributor

@4Luke4 4Luke4 commented Feb 15, 2023 •
edited
Loading

Tweaked version of my previous pull request about this topic (to tell the truth, it's also relevant for this and this).

Additionally, it now also expands to both BG:EE and BG2:EE for later compatibility with IWDification and the Seven Eyes spell.

(Technical note: when extracting effects to subspells, it uses op326 instead of op146 + op318/op324 in the subspell (so as to bypass the auto-pause bug).)

@4Luke4
GT_7EYES-O-MATIC
cfdf122 
Tweaked version of my previous pull request about this topic.
@4Luke4
Copy link
Contributor Author

4Luke4 commented May 23, 2023

@CamDawg

I can tweak this PR so as to include the new immunity system via op318 / op324 (which is probably better, so as to avoid overlapping code between me and DavidW).

Please let me know if can proceed...

@4Luke4 4Luke4 marked this pull request as draft October 13, 2023 12:21
@4Luke4 4Luke4 marked this pull request as ready for review April 21, 2024 10:46
@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 21, 2024 •
edited
Loading

@CamDawg
Ok, this is now ready for review. You might want to update the various eefixpack\files\tph\tbd_vfx_removal.tph (and probably something else too) accordingly (in particular, you might want to remove the subspell creation section since I already take care of it in a more sistematic way...)

Also, feel free to edit my 2da files (the SUBSPELL column) if you want to give subspells a specific name (otherwise my code will default to GET_UNIQUE_FILE_NAME)

@4Luke4
More externalizations
051ce9a 
Sleep, Ability Score Drain, Disease, Devour Brain, Death, Haste, Slow, Phase.
@4Luke4 4Luke4 mentioned this pull request Jul 1, 2024
Closed
@4Luke4
Copy link
Contributor Author

4Luke4 commented Jul 1, 2024 •
edited
Loading

@CamDawg
So, as you can see I've just externalized more opcode behaviors, most notably Sleep. I've splitted it into 5 different types (thoughts...?). Having said that, in order to fully work, the fixpack must get rid of flat immunity to opcode 39 (however, such a tweak can potentially break mods...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@4Luke4