Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped test failing because of cURL error #345

Merged
merged 2 commits into from
Oct 17, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed WPCS errors
christophherr committed Oct 13, 2018
commit f4b20b4d0ff24bbe247f2732bc88d5e7ab1b3bc8
2 changes: 1 addition & 1 deletion lib/api/image/class-beans-image-editor.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
g<?php
<?php
/**
* This class provides the means to edit an image.
*
Original file line number Diff line number Diff line change
@@ -39,9 +39,11 @@ public function test_should_return_false_when_fragment_is_empty() {
*/
public function test_should_return_empty_string_when_remote_does_not_exist() {
$fragment = 'http://beans.local/invalid-file.js';
$compiler = new _Beans_Compiler( [
'fragments' => [ $fragment ],
] );
$compiler = new _Beans_Compiler(
[
'fragments' => [ $fragment ],
]
);
$this->set_current_fragment( $compiler, $fragment );

// Run the test.
@@ -53,9 +55,11 @@ public function test_should_return_empty_string_when_remote_does_not_exist() {
*/
public function test_should_return_content_when_fragment_is_relative_url() {
$fragment = '//fonts.googleapis.com/css?family=Lato';
$compiler = new _Beans_Compiler( [
'fragments' => [ $fragment ],
] );
$compiler = new _Beans_Compiler(
[
'fragments' => [ $fragment ],
]
);
$this->set_current_fragment( $compiler, $fragment );

$content = $compiler->get_remote_content( $fragment );
@@ -72,9 +76,11 @@ public function test_should_return_content_when_fragment_is_relative_url() {
*/
public function test_should_return_content_when_fragment_is_http() {
$fragment = 'http://fonts.googleapis.com/css?family=Roboto';
$compiler = new _Beans_Compiler( [
'fragments' => [ $fragment ],
] );
$compiler = new _Beans_Compiler(
[
'fragments' => [ $fragment ],
]
);
$this->set_current_fragment( $compiler, $fragment );

$content = $compiler->get_remote_content( $fragment );
@@ -93,9 +99,11 @@ public function test_should_return_content_when_fragment_is_https() {
$this->markTestSkipped( 'wp_remote_get returns cURL error 60. Test must be revisited.' );

$fragment = 'https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css';
$compiler = new _Beans_Compiler( [
'fragments' => [ $fragment ],
] );
$compiler = new _Beans_Compiler(
[
'fragments' => [ $fragment ],
]
);
$this->set_current_fragment( $compiler, $fragment );

$content = $compiler->get_remote_content( $fragment );