Skip to content

Commit

Permalink
Split suppressons of thread.cc and messagequeue.cc.
Browse files Browse the repository at this point in the history
Most calls have either of these in the stack, meaning that pretty much
all races are suppressed.

BUG=
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17349004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7154 4adac7df-926f-26a2-2b94-8c16560cd09d
  • Loading branch information
pbos@webrtc.org committed Sep 11, 2014
1 parent 4b049fc commit b990674
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions webrtc/build/tsan_suppressions_webrtc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ char kTSanDefaultSuppressions[] =

// WebRTC specific suppressions.

// Split up suppressions covered previously by thread.cc and messagequeue.cc.
"race:rtc::MessageQueue::Quit\n"
"race:FileVideoCapturerTest::VideoCapturerListener::OnFrameCaptured\n"
"race:vp8cx_remove_encoder_threads\n"

// Usage of trace callback and trace level is racy in libjingle_media_unittests.
// https://code.google.com/p/webrtc/issues/detail?id=3372
"race:webrtc::TraceImpl::WriteToFile\n"
Expand All @@ -38,7 +43,6 @@ char kTSanDefaultSuppressions[] =

// libjingle_p2p_unittest
// https://code.google.com/p/webrtc/issues/detail?id=2079
"race:webrtc/base/messagequeue.cc\n"
"race:webrtc/base/testclient.cc\n"
"race:webrtc/base/virtualsocketserver.cc\n"
"race:talk/p2p/base/stunserver_unittest.cc\n"
Expand All @@ -48,7 +52,6 @@ char kTSanDefaultSuppressions[] =
"race:webrtc/base/logging.cc\n"
"race:webrtc/base/sharedexclusivelock_unittest.cc\n"
"race:webrtc/base/signalthread_unittest.cc\n"
"race:webrtc/base/thread.cc\n"

// third_party/usrsctp
// TODO(jiayl): https://code.google.com/p/webrtc/issues/detail?id=3492
Expand Down

0 comments on commit b990674

Please sign in to comment.