Skip to content

Commit

Permalink
Solve data race in Pulse audio implementation.
Browse files Browse the repository at this point in the history
BUG=3056, 1320
TEST=AutoTest

Mainly add threadchecker and remove unnecessary lock.
And some more styling working.
- audio_device_pulse_linux.cc: wrap lines longer than 80 chars. And add '.' to some comments around. Not do it to all places.
- audio_mixer_manager_pulse_linux.cc: Here I adopt some chromium practice. We use to do many things to the failure of pulse operation, which causes most of the data race issue. In chromium, if we failed to call any pulse function, we just fail it w/o use the previous results. Here I did same. Please check if it's good.

R=bjornv@webrtc.org, henrika@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/52479004

Cr-Commit-Position: refs/heads/master@{#9243}
  • Loading branch information
Brave Yao committed May 21, 2015
1 parent 8602a3d commit 1a07a1e
Show file tree
Hide file tree
Showing 5 changed files with 366 additions and 457 deletions.
Loading

0 comments on commit 1a07a1e

Please sign in to comment.