Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polls UI fixes and UX Improvements #612

Merged
merged 13 commits into from
Oct 2, 2024
Merged

Polls UI fixes and UX Improvements #612

merged 13 commits into from
Oct 2, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Sep 30, 2024 •
edited
Loading

🔗 Issue Link

Relates to https://stream-io.atlassian.net/browse/PBE-4287

🎯 Goal

Update the LLC Polls SDK changes and fixes some SwiftUI bugs, as well as improve a bit the UX.

🛠 Implementation

  • Fixes the vote progress view not having full width when the Poll is closed
  • Fixes checkbox not marked when current user voted from another device
  • Fix the latest voter logic incorrect (Channel Preview)
  • Changes the deprecated controller initializers
  • Improve voting UX by making it possible to tap the whole option as well
  • Reuse logic from LLC
  • Use latestVotes order directly from LLC, instead of sorting it on the UI side

🧪 Testing

Smoke testing to the SwiftUI Polls feature.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@nuno-vieira nuno-vieira requested a review from a team as a code owner September 30, 2024 09:10
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 30, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.11 MB 7.14 MB +34 KB 🟢

martinmitrevski
martinmitrevski approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the SwiftUI repo 😁 Looks good to me, let's just wait before merging the other PR into develop.

StreamChatSwiftUI.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@nuno-vieira nuno-vieira enabled auto-merge October 1, 2024 23:29
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
86 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nuno-vieira nuno-vieira merged commit 5e9de53 into develop Oct 2, 2024
11 checks passed
@nuno-vieira nuno-vieira deleted the add/polls-improvements branch October 2, 2024 00:22
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @Stream-SDK-Bot @martinmitrevski