Skip to content

Improve and modernize file handling in Harvest module #4368

Open
@dafeder

Description

Following up on #4276, we should try to eliminate the Drupal\common\Util\DrupalFiles class, since it's only used in Drupal\harvest\Transform\ResourceImporter and ResourceLocalizer service, uses soon-deprecated system_retrieve_file and does not handle file wrappers correctly.

If it's going to be too hard to remove DrupalFiles:

  • Refactor DrupalFiles to play nice with vfsStream and also to not use system_retrieve_file().
  • Turn Drupal\Tests\harvest\Functional\Transform\ResourceImporterTest into a kernel test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions