Renamed PartyMemberController to BattlePartyMemberController
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokozach
previously approved these changes
Nov 5, 2023
# Conflicts: # Assets/Scripts/Runtime/Converters/PartyMemberConverter.cs # Assets/Scripts/Runtime/MonoSystems/Party/PartyMonoSystem.cs
Sbrebbaz
previously approved these changes
Nov 5, 2023
yokozach
previously approved these changes
Nov 12, 2023
Sbrebbaz
approved these changes
Nov 13, 2023
yokozach
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PartyMemberControllertoBattlePartyMemberController.Notes:
This might seem small, but this will clarify things between Exploration scenes and Battle Scenes, as each scene will need its own separate, but ultimately unique
PartyMemberControllers. Potentially we may at some point findPartyMemberControlleror a similar script making a re-appearance, but this time as a inherited base class.Please make sure to get #186 merged in first. There will be conflicts, and it'll be more straightforward for me to just fix them on this PR by accepting "theirs" and throwing "ours" in the trash, in git speak.
For More Info See:
closes #184