Fix typings pipeline + cleanup (microsoft#19163)

GazimbeIsaac · Apr 21, 2022 · e9fefd2 · e9fefd2
1 parent 6c4bf81
commit e9fefd2
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 16 deletions.
diff --git a/build/azure-pipelines/publish-types/publish-types.yml b/build/azure-pipelines/publish-types/publish-types.yml
@@ -55,13 +55,13 @@ steps:
       git reset --hard upstream/master
       git push --force
 
-      # Update the type
+      # Update and format the typings file
       cd ..
       node build/azure-pipelines/publish-types/update-types.js
-
-      cd DefinitelyTyped
       TAG_VERSION=$(git describe --tags `git rev-list --tags --max-count=1`)
 
+      # Create and push the branch
+      cd DefinitelyTyped
       git diff --color | cat
       git add -A
       git status

diff --git a/src/sql/azdata.d.ts b/src/sql/azdata.d.ts
@@ -3556,7 +3556,7 @@ declare module 'azdata' {
 		 * Generally, a link has no need to set the `role` of the accessibilityInformation;
 		 * but it is exposed for situations that may require it.
 		 */
-		accessibilityInformation?: vscode.AccessibilityInformation
+		accessibilityInformation?: vscode.AccessibilityInformation;
 	}
 
 	export interface HyperlinkComponentProperties extends TitledComponentProperties {
@@ -3685,7 +3685,7 @@ declare module 'azdata' {
 		/**
 		 * context that will be passed to the commands.
 		 */
-		context: { [key: string]: string | boolean | number } | string | boolean | number | undefined
+		context: { [key: string]: string | boolean | number } | string | boolean | number | undefined;
 	}
 
 	export interface ListBoxProperties extends ComponentProperties {
@@ -3991,7 +3991,6 @@ declare module 'azdata' {
 		minimumHeight?: number;
 	}
 	export interface DiffEditorComponent extends DiffEditorProperties, Component {
-
 		/**
 		 * The left editor Uri which will be used as a reference for VSCode Language Service.
 		 * Currently this is auto-generated by the framework but can be queried after
@@ -4364,23 +4363,23 @@ declare module 'azdata' {
 		/**
 		 * The value selected on the slider. Default initial value is the minimum value.
 		 */
-		value?: number,
+		value?: number;
 		/**
 		 * The minimum value of the slider. Default value is 1.
 		 */
-		min?: number,
+		min?: number;
 		/**
 		 * The maximum value of the slider. Default value is 100.
 		 */
-		max?: number,
+		max?: number;
 		/**
 		 * The value between each "tick" of the slider. Default is 1.
 		 */
-		step?: number,
+		step?: number;
 		/**
 		 * Whether to show the tick marks on the slider. Default is false.
 		 */
-		showTicks?: boolean
+		showTicks?: boolean;
 		/**
 		 * The width of the slider, not including the value box.
 		 */
@@ -4483,7 +4482,15 @@ declare module 'azdata' {
 		 * @param renderFooter Specify whether or not to render the Dialog footer, default is true.
 		 * @param dialogProperties Positional data prior to opening of dialog, default is undefined.
 		 */
-		export function createModelViewDialog(title: string, dialogName?: string, width?: DialogWidth, dialogStyle?: DialogStyle, dialogPosition?: DialogPosition, renderHeader?: boolean, renderFooter?: boolean, dialogProperties?: IDialogProperties): Dialog;
+		export function createModelViewDialog(
+			title: string,
+			dialogName?: string,
+			width?: DialogWidth,
+			dialogStyle?: DialogStyle,
+			dialogPosition?: DialogPosition,
+			renderHeader?: boolean,
+			renderFooter?: boolean,
+			dialogProperties?: IDialogProperties): Dialog;
 
 		export interface ModelViewDashboard {
 			/**
@@ -4628,19 +4635,19 @@ declare module 'azdata' {
 			/**
 			 * x position of the dialog relative to the parent element
 			 */
-			xPos: number,
+			xPos: number;
 			/**
 			 * y position of the dialog relative to the parent element
 			 */
-			yPos: number,
+			yPos: number;
 			/**
 			 * width of the dialog
 			 */
-			width: number,
+			width: number;
 			/**
 			 * height of the dialog
 			 */
-			height: number
+			height: number;
 		}
 
 		// Model view dialog classes