Fix that encoded fields ending in a question mark were treated as inv…

…alid and not decoded, returning the raw encoded field
GChuf · Mar 14, 2021 · 51c05e0 · 51c05e0
1 parent c076f99
commit 51c05e0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.rdoc b/CHANGELOG.rdoc
@@ -3,6 +3,7 @@
 Bugs:
 * Fix duplicate dots at beginning of lines. (c960657)
 * Don't alter attachment filenames when Content-Type parsing fails. (nbianca)
+* Fix decoding fields ending in question marks. (jeremy)
 
 
 == Version 2.7.1 (2018-10-13)

diff --git a/lib/mail/constants.rb b/lib/mail/constants.rb
@@ -34,8 +34,8 @@ module Constants
     ATOM_UNSAFE   = /[#{Regexp.quote aspecial}#{control}#{sp}]/n
     PHRASE_UNSAFE = /[#{Regexp.quote aspecial}#{control}]/n
     TOKEN_UNSAFE  = /[#{Regexp.quote tspecial}#{control}#{sp}]/n
-    ENCODED_VALUE = /\=\?([^?]+)\?([QB])\?[^?]*?\?\=/mi
-    FULL_ENCODED_VALUE = /(\=\?[^?]+\?[QB]\?[^?]*?\?\=)/mi
+    ENCODED_VALUE = /\=\?([^?]+)\?([QB])\?[^?]*?\?+\=/mi
+    FULL_ENCODED_VALUE = /(\=\?[^?]+\?[QB]\?[^?]*?\?+\=)/mi
 
     EMPTY          = ''
     SPACE          = ' '

diff --git a/spec/mail/encodings_spec.rb b/spec/mail/encodings_spec.rb
@@ -333,6 +333,10 @@
       expect(Mail::Encodings.value_decode("=?utf-8?Q?a a?=")).to eq "a a"
     end
 
+    it "should decode a string ending with an unencoded question mark" do
+      expect(Mail::Encodings.value_decode("=?UTF-8?Q?=C3=A5???=")).to eq "å??"
+    end
+
     it "should treat unrecognized charsets as binary" do
       if RUBY_VERSION >= "1.9"
         expect(Mail::Encodings.value_decode("=?ISO-FOOO?Q?Morten_R=F8verdatt=E9r?=")).to eq "Morten R�verdatt�r"