Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet calculate gas performance #1794

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

feat: wallet calculate gas performance #1794

wants to merge 12 commits into from

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Jan 22, 2025 •
edited
Loading

Summary

  • Centralized provider logic, avoid recreating provider instances for the same network url
  • Sped up account balance calculation by making requests in parallel
  • Sped up gas calculation in SendMachine and TxRequestMachine by using already present information on account/balance from accountMachine instead of re-fetching
  • Sped up gas calculation in SendMachine and TxRequestMachine by merging calculations of default tip and gas limit into a single parallelized promise.
  • Decrease unnecessarily long delay in tx and send machines while waiting for a possible new user input

@arthurgeron arthurgeron changed the title improve: wallet calculate gas performance feat: wallet calculate gas performance Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio will be requested when the pull request is marked ready for review luizstacio is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight will be requested when the pull request is marked ready for review LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco will be requested when the pull request is marked ready for review helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas will be requested when the pull request is marked ready for review rodrigobranas is a code owner

@nelitow nelitow Awaiting requested review from nelitow nelitow will be requested when the pull request is marked ready for review nelitow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve performance of transaction approval from dapp
1 participant
@arthurgeron