Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update support to fuel-core v0.17.1 (beta-3) #775

Merged
merged 20 commits into from
Feb 14, 2023
Merged

feat: Update support to fuel-core v0.17.1 (beta-3) #775

merged 20 commits into from
Feb 14, 2023

Conversation

luizstacio
Copy link
Member

@luizstacio luizstacio commented Feb 10, 2023 •
edited
Loading

This PR;

  • Updates docker to use the latest version of fuel-core v0.17.1.
  • Add changes to docker-compose to solve compatibility issues (platform: linux/amd64).
  • Add configs to the fuel node info required for the new fuel-core.
  • Remove tests related to sending messages as they are not supported.
  • Make changes to the provider to support new queries.
  • Add retry strategy on fetch (temp)

NOTE:

  • After this code is merged because of incompatible fields on the GraphQL queries removed on the update, fuel-ts will no longer support beta-2 or fuel-core < v0.17.1. We should keep this in mind to merge PRs required to fix issues before this.
  • Improve the strategy to fetch expand backoff using subscriptions Implement transaction subscriptions #782

close: #768

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
93.23% (+0.69% 🔼)
 4226/4533
🟢 Branches
80.02% (+3.41% 🔼)
 745/931
🟢 Functions
90.39% (+1.12% 🔼)
 837/926
🟢 Lines
93.08% (+0.56% 🔼)
 4063/4365
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / hdwallet.ts
 94.85% 80.39% 100% 95.79%
🟢
... / index.ts
 100% 100% 100% 100%
🟢 signer/src/index.ts 100% 100% 100% 100%
🟢
... / signer.ts
 100% 100% 100% 100%
🟢 hasher/src/index.ts 100% 100% 100% 100%
🟢
... / hasher.ts
 97.56% 87.5% 100% 97.56%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / coin-quantity.ts
 100% 83.33% 100% 100%
🟢
... / coin.ts
 100% 100% 0% 100%
🟢
... / operations.ts
 84.35% 100% 68.42% 84.21%
🟡
... / provider.ts
 74.73% 62.5% 73.91% 73.71%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / consts.ts
 100% 100% 100% 100%
🟢
... / resource.ts
 83.33% 100% 50% 80%
🟢
... / index.ts
 100% 100% 100% 100%
🟡
... / input.ts
 73.33% 50% 100% 71.43%
🟢
... / output.ts
 92.86% 85.71% 100% 92.31%
🟡
... / transaction-request.ts
 76.4% 64% 67.8% 76.92%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / receipts.ts
 92.31% 83.33% 100% 91.67%
🟢
... / fee.ts
 100% 100% 100% 100%
🟢
... / sleep.ts
 100% 100% 100% 100%
🟢
... / storage-slot.ts
 84.62% 50% 100% 83.33%
🟢
... / witness.ts
 100% 100% 100% 100%
🟢
... / transaction-response.ts
 94.59% 72.73% 100% 94.59%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 50% 100%
🟢
... / contract-factory.ts
 86.49% 66.67% 83.33% 86.49%
🟢
... / util.ts
 96.88% 0% 100% 96%
🟢 merkle/src/index.ts 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / contract.ts
 95.45% 85.71% 100% 95.24%
🟢
... / invocation-scope.ts
 100% 57.14% 100% 100%
🟢
... / base-invocation-scope.ts
 100% 92.86% 100% 100%
🟢
... / scripts.ts
 96.15% 87.5% 100% 96%
🟢 script/src/index.ts 100% 100% 100% 100%
🟢
... / script.ts
 82.76% 62.5% 83.33% 82.76%
🟢
... / errors.ts
 100% 83.33% 100% 100%
🟢 script/src/utils.ts 100% 60% 100% 100%
🟢
... / constants.ts
 100% 100% 100% 100%
🔴
... / scripts.ts
 50% 100% 0% 50%
🟢
... / multicall-bin.ts
 100% 100% 100% 100%
🟢
... / invocation-results.ts
 97.62% 66.67% 100% 97.56%
🟢
... / multicall-scope.ts
 100% 100% 100% 100%
🟢
... / utils.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / wallet-manager.ts
 100% 100% 100% 100%
🟢
... / mnemonic-vault.ts
 94.12% 87.5% 100% 94.12%
🟢
... / privatekey-vault.ts
 95.24% 60% 100% 95.24%
🟢
... / wallet-manager-spec.ts
 100% 100% 100% 100%
🟢
... / wallet.ts
 100% 100% 100% 100%
🟢
... / constants.ts
 100% 100% 100% 100%
🟢
... / wallets.ts
 95.45% 100% 85.71% 100%
🟡
... / base-locked-wallet.ts
 75.96% 60.87% 68.75% 75.96%
🟢
... / base-unlocked-wallet.ts
 89.66% 100% 88.89% 89.29%
🟢 wallet/src/index.ts 100% 100% 100% 100%
🟢
... / wallet-spec.ts
 100% 100% 100% 100%
🟢
... / hdwallet-spec.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / ExampleContractAbi__factory.ts
 83.33% 100% 50% 83.33%
🟢 fuels/src/index.ts 100% 100% 100% 100%

Test suite run success

705 tests passing in 97 suites.

Report generated by 🧪jest coverage report action from 6577db8

camsjams
camsjams approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

packages/wallet/src/transfer.test.ts Show resolved Hide resolved
camsjams
camsjams previously approved these changes Feb 10, 2023
View reviewed changes
docker-compose.yml Show resolved Hide resolved
digorithm
digorithm reviewed Feb 10, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
luizstacio and others added 3 commits February 10, 2023 08:16
@luizstacio @digorithm
Update packages/providers/fuel-core-schema.graphql
b67853c 
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@luizstacio @digorithm
Update docker-compose.yml
6d2f5ca 
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@luizstacio
fix: add retry stratefy on fetch
9ff5761
@luizstacio luizstacio marked this pull request as ready for review February 13, 2023 18:26
@luizstacio luizstacio self-assigned this Feb 13, 2023
@luizstacio luizstacio requested a review from digorithm February 13, 2023 23:37
@luizstacio luizstacio mentioned this pull request Feb 14, 2023
Closed
arboleya
arboleya previously approved these changes Feb 14, 2023
View reviewed changes
digorithm
digorithm approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for doing this @luizstacio!

@luizstacio luizstacio merged commit 3aa7ed4 into master Feb 14, 2023
@luizstacio luizstacio deleted the ls/fix/768 branch February 14, 2023 16:18
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@camsjams camsjams camsjams approved these changes

@arboleya arboleya arboleya approved these changes

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@luizstacio luizstacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fuel-core to version v0.17.0
4 participants
@luizstacio @arboleya @camsjams @digorithm