Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove receipt coders #3551

Merged
merged 13 commits into from
Jan 6, 2025
Merged

chore!: remove receipt coders #3551

merged 13 commits into from
Jan 6, 2025

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Jan 6, 2025 •
edited
Loading

Release notes

In this release, we:

  • Removed all receipt coders

Breaking Changes

All previously deprecated receipt coders have been removed. These classes were barely used aside from a few internal helpers, which were converted to utility functions.

// before
const messageId = ReceiptMessageOutCoder.getMessageId({
  sender,
  recipient,
  nonce,
  amount,
  data,
});

const assetId = ReceiptMintCoder.getAssetId(contractId, subId);

const assetId = ReceiptBurnCoder.getAssetId(contractId, subId);
// after
import { getMessageId, getAssetId } from 'fuels'

const messageId = getMessageId({
  sender,
  recipient,
  nonce,
  amount,
  data,
});

const assetId = getAssetId(contractId, subId);

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the chore Issue is a chore label Jan 6, 2025
@Torres-ssf Torres-ssf self-assigned this Jan 6, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 6:38pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 6:38pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 6:38pm

@Torres-ssf Torres-ssf marked this pull request as ready for review January 6, 2025 18:00
@Torres-ssf Torres-ssf enabled auto-merge (squash) January 6, 2025 18:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Coverage Report:

Lines Branches Functions Statements
76.95%(-0.79%) 70.35%(-0.18%) 74.97%(-0.32%) 76.96%(-0.74%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)
🔴 ✨ packages/transactions/src/receipt.ts 100%
(+100%)		 75%
(+75%)		 100%
(+100%)		 100%
(+100%)

@Torres-ssf Torres-ssf merged commit f132203 into master Jan 6, 2025
24 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/remove-receipt-coders branch January 6, 2025 19:29
@fuel-service-user fuel-service-user mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove receipt coders
4 participants
@Torres-ssf @arboleya @maschad @nedsalk