Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust paths and globals in fuels init #3510

Merged
merged 8 commits into from
Jan 2, 2025
Merged

fix: adjust paths and globals in fuels init #3510

merged 8 commits into from
Jan 2, 2025

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Dec 31, 2024 •
edited by fuel-service-user
Loading

Release notes

In this release, we:

  • Fixed an issue when using multiple paths (or globals) in fuels init

Summary

In commander, I had to inform variadic options with [name...], i.e.:

new Option(`-p, --predicates [paths...]`, `Relative paths to Predicates`)

Docs:

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@arboleya arboleya added the bug Issue is a bug label Dec 31, 2024
@arboleya arboleya self-assigned this Dec 31, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:00am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:00am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:00am

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3510 will degrade performances by 16.53%

Comparing aa/fix/fuels-init-paths (c658245) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master aa/fix/fuels-init-paths Change
❌ should successfully transfer a single asset between wallets (x20 times) 58.6 ms 70.2 ms -16.53%

@arboleya arboleya marked this pull request as ready for review December 31, 2024 08:56
@arboleya arboleya changed the title fix: fuels init paths and globals handling fix: paths and globals in fuels init Dec 31, 2024
@arboleya arboleya enabled auto-merge (squash) January 2, 2025 08:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Coverage Report:

Lines Branches Functions Statements
77.83%(+0%) 70.5%(+0%) 75.5%(+0%) 77.79%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit 11fcd7b into master Jan 2, 2025
23 checks passed
@arboleya arboleya deleted the aa/fix/fuels-init-paths branch January 2, 2025 09:16
@fuel-service-user fuel-service-user mentioned this pull request Jan 2, 2025
Open
@arboleya arboleya changed the title fix: paths and globals in fuels init fix: adjust paths and globals in fuels init Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@arboleya arboleya

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve paths validation/expansion on fuels init command
4 participants
@arboleya @danielbate @petertonysmith94 @nedsalk