Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation and handling of unsafe integers #3491

Merged
merged 9 commits into from
Jan 2, 2025
Merged

fix: validation and handling of unsafe integers #3491

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
858c9b6
feat: added error condition around number values that are too big
petertonysmith94 Dec 19, 2024
2a4d6cf
chore: changeset
petertonysmith94 Dec 19, 2024
a0f983f
chore: add comment + altered test
petertonysmith94 Dec 20, 2024
b68944c
Update .changeset/orange-moles-leave.md
petertonysmith94 Dec 23, 2024
8faf42d
Update packages/abi-coder/src/encoding/coders/BigNumberCoder.test.ts
petertonysmith94 Dec 30, 2024
eb24fc1
chore: improving error message
petertonysmith94 Dec 30, 2024
c1eed36
chore: fix error messages
petertonysmith94 Dec 30, 2024
53f737c
Merge branch 'master' into ps/fix/issue-with-big-numbers
arboleya Dec 31, 2024
37a2b9f
Merge branch 'master' into ps/fix/issue-with-big-numbers
petertonysmith94 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix error messages
  • Loading branch information
@petertonysmith94
petertonysmith94 committed Dec 30, 2024
commit c1eed364bf6eb1feac713ef8937df5779ce8c6af
4 changes: 2 additions & 2 deletions packages/abi-coder/src/encoding/coders/BigNumberCoder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('BigNumberCoder', () => {
() => coder.encode(value),
new FuelError(
ErrorCode.ENCODE_ERROR,
'Invalid u64 type - too large. Number can only safely handle up to 53 bits.'
'Invalid u64 type - number value is too large. Number can only safely handle up to 53 bits.'
)
);
});
Expand All @@ -64,7 +64,7 @@ describe('BigNumberCoder', () => {
() => coder.encode(value),
new FuelError(
ErrorCode.ENCODE_ERROR,
'Invalid u64 type - too large. Number can only safely handle up to 53 bits.'
'Invalid u64 type - number value is too large. Number can only safely handle up to 53 bits.'
)
);
});
Expand Down
Loading