Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add method to hash TX on TransactionRequest classes #1485

Merged
merged 34 commits into from
Dec 13, 2023
Merged

feat: add method to hash TX on TransactionRequest classes #1485

merged 34 commits into from
Dec 13, 2023

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Dec 7, 2023 •
edited
Loading

@Torres-ssf Torres-ssf added the feat Issue is a feature label Dec 7, 2023
@Torres-ssf Torres-ssf self-assigned this Dec 7, 2023
@Torres-ssf Torres-ssf changed the title st: add method to hash TX on TransactionRequest classes feat: add method to hash TX on TransactionRequest classes Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
86.61% (-0.04% 🔻)
 6063/7000
🟡 Branches
70.7% (+0.16% 🔼)
 941/1331
🟡 Functions
77.35% (-0.22% 🔻)
 997/1289
🟢 Lines
86.59% (-0.04% 🔻)
 5806/6705
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟡
... / hash-transaction.ts
 62.79% 44.44% 100% 62.79%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / create-transaction-request.ts
73.08% (-1.92% 🔻)
 57.14%
37.5% (-5.36% 🔻)
73.08% (-1.92% 🔻)
🔴
... / script-transaction-request.ts
48.08% (+0.08% 🔼)
 58.33%
22.22% (-1.31% 🔻)
49.02% (+0.04% 🔼)
🟢
... / account.ts
89.02% (+0.27% 🔼)
45.45% (-10.1% 🔻)
92.86% (+0.55% 🔼)
89.02% (+0.27% 🔼)
🟡
... / predicate.ts
70.49% (-1.92% 🔻)
43.75% (-6.25% 🔻)
72.73% (-5.05% 🔻)
70.49% (-1.92% 🔻)
🔴
... / base-invocation-scope.ts
8.85% (-0.8% 🔻)
 0% 0%
8.93% (-0.81% 🔻)
🔴
... / hasher.ts
58.33% (-12.58% 🔻)
100% (+55.56% 🔼)
66.67% (-33.33% 🔻)
58.33% (-12.58% 🔻)

Test suite run success

1474 tests passing in 259 suites.

Report generated by 🧪jest coverage report action from 492c5d8

@Torres-ssf Torres-ssf marked this pull request as ready for review December 8, 2023 13:29
@Torres-ssf Torres-ssf closed this Dec 8, 2023
@Torres-ssf Torres-ssf reopened this Dec 8, 2023
danielbate
danielbate previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments but will let you decide on priority

packages/providers/src/transaction-request/create-transaction-request.ts Show resolved Hide resolved
apps/docs/src/guide/predicates/send-and-spend-funds-from-predicates.md Show resolved Hide resolved
@Torres-ssf Torres-ssf dismissed stale reviews from danielbate and arboleya via d923865 December 12, 2023 12:44
arboleya
arboleya reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider merging this after beta-5?

Just wondering if some change could cascade into issues for the FE.

@Torres-ssf
Copy link
Contributor Author

Torres-ssf commented Dec 12, 2023 •
edited
Loading

Should we consider merging this after beta-5?

Just wondering if some change could cascade into issues for the FE.

@arboleya We can definitely postpone this one.

But the changes made it here should not cause any breaking changes.

@arboleya arboleya self-requested a review December 12, 2023 18:43
@Torres-ssf Torres-ssf enabled auto-merge (squash) December 13, 2023 18:24
@Torres-ssf Torres-ssf merged commit a3ca540 into master Dec 13, 2023
10 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/hash-tx-on-transaction-request branch December 13, 2023 18:31
@github-actions github-actions bot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-add API to get TX ID before submitting it Implement getTransactionId for transfers on the Predicate class
3 participants
@Torres-ssf @arboleya @danielbate