@danielbate What's the difference between what each method will return? Please, consider posting both returned objects in full so we can compare them. While I'm happy with the rationale, I'm not sure the API is quite there yet, but we can discuss it further. 🙂

Based on this check:

/**
 * If totalFee is provided it means that the TX was already processed and we could extract the fee
 * from its status
 */
if (totalFee) {
  return totalFee;
}

fetching the gasPrice isn't necessary for the API use case you have proposed as the transaction will always be processed because tx.waitForResult is called. What we can do to remove this call is we can conditionally fetch the gasPrice doing something like this:

const { totalFee } = processGraphqlStatus(this.status ?? this.gqlTransaction?.status);
const gasPrice = !totalFee && await this.provider.getLatestGasPrice();

I agree with @nedsalk's suggestion, it seems the best approach.

Since TransactionResponse.getTransactionSummary is only called after a successful transaction result (i.e. when the status update is successful), the totalFee will always be available within the transaction status object. In this case fetching the gasPrice is not required.

And for cases where the user explicitly calls TransactionResponse.getTransactionSummary, the if statement suggested by @nedsalk should do the trick if the status has not been updated to successful yet.

This issue initially made the below proposition, but has been superseded by comments from @nedsalk and @Torres-ssf 👏🏻

Our current TransactionResponse instance contains a full transaction summary. This summary performs an additional network request to retrieve the latest gas price in order to compute the transaction fee. For an SDK consumer just concerned with the transaction success this could be a point of redundancy and unnecessary network lag.

We should introduce a slimmer version of the TransactionResponse that contains only what is available from transaction submitted transaction and it's returned receipts.

The proposed API:

const call = contract.functions.increment().call();
const response = await call.waitForResult({ slim: true });
// response.fee = undefined

const txRequest = wallet.createTransfer(recipient, 100));
const tx = wallet.sendTransaction(txRequest);
const response = await tx.waitForResult({ slim: true });
// response.fee = undefined

const txRequest = wallet.createTransfer(recipient, 100);
const tx = wallet.sendTransaction(txRequest);
const response = await tx.waitForResult();
// response.fee = 0x12

We do have the calculateTxFeeForSummary but we may want to make this more explicit (e.g. calculateTxFee) given this won't be so readily available in the response.