Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade electron from 16 > 19 #2406

Closed
wants to merge 5 commits into from
Closed

Upgrade electron from 16 > 19 #2406

wants to merge 5 commits into from

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type
Please select what type of pull request this is:

  • Feature Implementation

Related issue
Might or might not fix issue in #2113

Closes #2358

Description
16.x is not supported anymore
From https://www.electronjs.org/blog/electron-17-0
image

Breaking change in 17.x =

Breaking change in 18.x =

Breaking change in 19.x

Screenshots (if appropriate)
N/A

Testing (for code that is not small enough to be easily understandable)
Use test build daily in different OS

Desktop (please complete the following information):

  • OS: MacOS
  • OS Version: 12.1
  • FreeTube version: 5d40485

Additional context
Add any other context about the problem here.

@PrestonN PrestonN enabled auto-merge (squash) July 20, 2022 08:23
@absidue
Copy link
Member

absidue commented Jul 20, 2022

CI build artifacts here: https://github.com/absidue/FreeTube/actions/runs/2703335841

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 20, 2022
@wildwestrom
Copy link

wildwestrom commented Jul 24, 2022 •
edited
Loading

Got a couple errors when running pacman -U on the .pacman file.
I don't know how to fix it (yet), but I figured I should leave this feedback for now.

(1/4) Arming ConditionNeedsUpdate...
(2/4) Updating icon theme caches...
(3/4) save-package-list.hook
error: local database is inconsistent: name mismatch on package freetube-0.17.0-nightly
error: local database is inconsistent: version mismatch on package freetube-0.17.0-nightly
(4/4) Updating the desktop file MIME type cache...

So far so good. Again testing with the wayland ozone platform.

@PikachuEXE PikachuEXE force-pushed the update/electron/19.x branch from 670d884 to 6d96899 Compare July 28, 2022 01:33
@PikachuEXE PikachuEXE force-pushed the update/electron/19.x branch from 6d96899 to 145fc42 Compare July 28, 2022 01:35
@wildwestrom
Copy link

@absidue Could you please run another CI artifact so I can test the latest commit?

@absidue
Copy link
Member

absidue commented Jul 28, 2022

@wildwestrom The artifacts will be here when the build finishes: https://github.com/absidue/FreeTube/actions/runs/2756087579 (so they will probably be done by the time you see this).

@wildwestrom
Copy link

wildwestrom commented Jul 29, 2022 •
edited
Loading

For anyone who hasn't dealt with a .pacman file, it's apparently pretty easy to use.
First unzip the tarball. Then run pacman -U to install it. Before installing another nightly, you need to manually remove the previous one with pacman -R. Also know that pacman will complain about the database being inconsistent, but that goes away after uninstalling.

@toby63
Copy link

toby63 commented Aug 2, 2022 •
edited
Loading

Just tried a build (freetube-git (with minor modifications to use electron19)) with this patch on Manjaro Linux, all seems to work great.
Electron19 also seems to improve performance and UI loading etc.

I am using Wayland by the way.

@PikachuEXE
Copy link
Collaborator Author

Anyone wanna try electron 20? 🤣

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

sure would u like to open up a PR 😬

@PikachuEXE
Copy link
Collaborator Author

@efb4f5ff-1298-471a-8973-3d47447115dc
#2448

Testing it is another thing...

@PikachuEXE PikachuEXE force-pushed the update/electron/19.x branch from 466b5a4 to 0f774cd Compare August 5, 2022 11:28
@PikachuEXE PikachuEXE added electron being electron Electron related bugs and trickeries PR: WIP labels Aug 5, 2022
@PikachuEXE
Copy link
Collaborator Author

PIP fix included
Should we remove the WIP label?

Merged
1 task
auto-merge was automatically disabled August 26, 2022 07:46

Pull request was closed

@github-actions github-actions bot removed PR: waiting for review For PRs that are complete, tested, and ready for review PR: WIP labels Aug 26, 2022
@PikachuEXE PikachuEXE deleted the update/electron/19.x branch September 1, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
electron being electron Electron related bugs and trickeries PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PikachuEXE @absidue @wildwestrom @toby63 @efb4f5ff-1298-471a-8973-3d47447115dc