-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CORTEX R4 demo to use linked resources #1272 #1273
Conversation
@@ -0,0 +1,59 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead remove both these scripts and use linked resources instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would second this. Just symlink the resources that are copied and get rid of the scripts. The only real caveat against this is that prior to Vista, Windows did not support symlinks, but I would consider that to be a negligible issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I will update this PR with that change instead. I have it working locally after a bit of messing around with relative paths.
Where does the documentation live? This section in the docs will also need updating since this script will no longer exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mryall-mawson,
I will update the documentation on the website for you.
Best,
Jason Carroll
Instead of keeping the symboic links, I was thinking of using Eclipse's linked folder and resource filters to filter the files in those folders. Please try the following patch and let me know what you think about it - 0001-Update-CORTEX_R4_RM48_TMS570_CCS5-project.patch. Note that I used CCS v12. |
Ah okay. I've updated the PR to use this approach. There were a few problems with your patch that I've fixed up:
Testing note: I found that Eclipse retains some state for linked resources even after the resource is removed from the
After playing around with it, I think this approach relies on a lot of IDE magic and obscure settings screens. So I would probably find the symlinks easier to grok coming at the project fresh. But it's your project, so happy to go with your recommendation.
I'm also using CCS 12. Perhaps we should remove the "_CCS5" suffix from the demo project and path name? I don't think preserving compatibility with an old, unsupported IDE version should be a goal for this demo. I'd suggest doing that as a separate ticket+PR however, so we don't delay this work with further changes. |
I also tested this on real TMS570 hardware today (using the symlinked version), and it worked fine. |
Updates complete - please re-review when you get a chance, thanks @aggarg @jasonpcarroll. |
Thank you for addressing these problems. I guess I made these changes for only one target and did not realize that there were 3 more. When I built the project with the current changes, I needed to update the "Runtime support library" to automatic so that CSS builds the library when the project is used first time after installation - 0001-Set-library-management-to-autometic.patch. Please take a look at this and let me know what you think. Thank you for your contribution! |
@mryall-mawson Did you get a chance to look at the change above? |
That sounds like a handy fix. I had to work out how to do that manually with Unfortunately I haven’t had time to review or test it yet. I’m at a conference next week as well, so it may be two weeks until I get a chance. We could potentially split this into a separate issue and PR if you want? |
Thank you for confirming. Lets do it this way. And thank you for your contribution! |
Replace batch script in Cortex R4 demo with linked resources, to support non-Windows dev platforms.
Description
Two commits:
FreeRTOS/Demo/CORTEX_R4_RM48_TMS570_CCS5/CreateProjectDirectoryStructure.bat
, and replace it with linked resourcesTest Steps
I tested this by doing a clean build of the demo project with Code Composer Studio 12. It compiles successfully with the symlinks instead of copied files.
I've also tested it on a TMS570-based board and it loaded, ran and debugged successfully.
Checklist:
Related Issue
#1272
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.