New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(PD): ThreadSize enum simplification #18682

Open

alfrix wants to merge 2 commits into FreeCAD:main from alfrix:threads_enums

+52 −114

Contributor

alfrix commented Dec 22, 2024

refactor to get the designations from the ThreadDescription instead of having a bunch of arrays duplicating the same thing

also added a test for threadtype change to check that is working properly

alfrix added 2 commits

December 22, 2024 17:21


          refactor(PD): dynamically set threadSize enums

3f58f83


          feat(PD): create a test for threadType changes and the threadSize aut…

d2817e8

…o-select

github-actions bot added the Mod: Part Design label

Member

chennes commented Dec 23, 2024

@AjinkyaDahale is going to look at this.

yorikvanhavre requested a review from AjinkyaDahale

December 23, 2024 17:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Part Design