Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: auto-fill version of about dialog image #18617

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ein-shved
Copy link
Contributor

Additionally - draws pretty warning-tape style border in case of development version

This is alternative to #18599

image

Additionally - draws pretty warning-tape style border in case of
development version

Change-Id: Iecc1063a8b21f8461924b3ecb95d00db3ccf5dbe
@github-actions github-actions bot added the Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Dec 19, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 19, 2024

@FreeCAD/design-working-group FYI

@hyarion
Copy link
Contributor

hyarion commented Dec 19, 2024

Coding graphics usually makes it difficult to redesign later, especially for non-coders.

How about using an overlay svg for dev additions instead?

@kadet1090
Copy link
Member

Yeah, SVG overlay would be better and easier to maintain later

@ein-shved
Copy link
Contributor Author

@hyarion @kadet1090, I am ok with that! But the problem is that I am just programmer and very far from graphic design. So for me much easy to draw lines programmatically than draw an image in graphic editor. So if you could provide me with and overlay image and re-check updated about image - this will be great!

@hyarion
Copy link
Contributor

hyarion commented Dec 20, 2024

I'm almost done recreating the images as svgs.

@hyarion
Copy link
Contributor

hyarion commented Dec 21, 2024

Here's three svg files:
freecadabout
freecadabout-dev
freecadabout-dev-overlay

They are all versions of the same file, with just different elements visible/hidden.
I couldn't find the original working file, so I created one myself and tried to make it look close to the original version, but it's not a 1:1 copy. For instance, the logo has been slightly resized and grid is adjusted to fit the logo and be pixel aligned.

In theory it would be possible to set layer ('g') with id dev_layer's style to display:none to hide it, display:inline to show it

There's also a hidden version text element that is configured to be dynamically adjustable (id version_text), but that would require that the font is included, which I don't think it is at the moment, hence hidden.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 22, 2024

looks great!

luzpaz added a commit to luzpaz/FreeCAD-snap that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants