Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gui: Add about image for dev version #18599

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Gui: Add about image for dev version #18599

wants to merge 1 commit into from
+7 −1

Conversation

ein-shved
Copy link
Contributor

Rework of #17030

image
Dev window is above, my system freecad's window is below.

@github-actions github-actions bot added the Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Dec 18, 2024
@ein-shved ein-shved mentioned this pull request Dec 18, 2024
Closed
hyarion
hyarion reviewed Dec 18, 2024
View reviewed changes
src/Gui/DlgAbout.cpp Outdated Show resolved Hide resolved
hyarion
hyarion approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@hyarion hyarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and paths looks good.
I’ve not been part of the design discussion so I can’t verify that, but it looks similar the previous PR that people where happy with so I assume it is good.

@ein-shved
Copy link
Contributor Author

Code and paths looks good.

Thank you! Waiting for @luzpaz @maxwxyz and @chennes then!))

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 19, 2024

I like that it is dynamically set for dev version but maybe we can get rid of the version number? That way it does need to be updated separately and the actual number is right below in that dialog

@wwmayer
Copy link
Contributor

wwmayer commented Dec 19, 2024

Can you rebase your PR to get rid of the annoying pre-commit change, please?

@qewer33 @ein-shved
Gui: Add about image for dev version
f8460c7 
Change-Id: Iecc1063a8b21f8461924b3ecb95d00db3ccf5dbe
luzpaz added a commit to luzpaz/FreeCAD-snap that referenced this pull request Dec 19, 2024
@luzpaz
Test PR 18599
f5cccb5 
* FreeCAD/FreeCAD#18599
@luzpaz luzpaz mentioned this pull request Dec 19, 2024
Closed
@ein-shved ein-shved mentioned this pull request Dec 19, 2024
Draft
@ein-shved
Copy link
Contributor Author

I like that it is dynamically set for dev version but maybe we can get rid of the version number? That way it does need to be updated separately and the actual number is right below in that dialog

Suggested alternative here #18617

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 20, 2024

So which PR should be considered?

@ein-shved
Copy link
Contributor Author

So which PR should be considered?

I am do not know, which way is the best for project, but I personally prefer auto-generated way. But that way required more time.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 22, 2024

I'm setting this to draft to decide which of those to merge

@maxwxyz maxwxyz marked this pull request as draft December 22, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyarion hyarion hyarion approved these changes

Assignees
No one assigned
Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ein-shved @maxwxyz @wwmayer @hyarion @qewer33