-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAM: Fixed script-style postprocessors getting the wrong __name__ #18538
base: main
Are you sure you want to change the base?
Conversation
9a1dc2f
to
224ae96
Compare
I don't know how to do a "backport" but would be happy to learn :-) This PR should be able to be applied to the 1.0 release tree without issues as far as I know. |
@LarryWoestman we'll do the backport for a 1.0.1 bugfix release |
224ae96
to
7dfb66b
Compare
I was able to figure out a test for this issue, so added the test as well with the latest force-push. |
7dfb66b
to
7bfd81e
Compare
@LarryWoestman could you resolve the conflict in this PR? |
I would be happy to fix it if I could figure out what the conflict is. Can you be more detailed about what the problem is or what I can do to figure out what the problem is? Thanks! |
@LarryWoestman in Placement.cpp |
I noticed that #18539 was already merged when it was supposed to wait until this issue was merged. That might be the cause of the conflict since the conflict isn't in code that I modified. |
Also added a test that the __name__ of the postprocessor is correct
f33a737
to
b0a90ab
Compare
I have force pushed an up-to-date version of the "staging" branch. |
I don't see any pre-commit-ci bot changes to this force push, so perhaps the problem has gone away? :-) |
This fixes #18493
Script-style (legacy) postprocessors had a name of "script_module" instead of the postprocessor name. This value shows up in a comment in the generated g-code for most postprocessors. This causes confusion for the users of the postprocessors. This PR passes the postprocessor name to the WrapperPost class so it can be used when invoking the postprocessor.
Also removed a "syspath = sys.path" line because syspath wasn't being used anywhere in the code.