Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table item text color fix #15937

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MisterMakerNL
Copy link
Contributor

@MisterMakerNL MisterMakerNL commented Aug 18, 2024

Attempt to fix:
#8168 (comment)
This fix has 2 issues:
If you create a table in a dark-theme, then when you switch to light-theme the text stays white, but the background changes to white and it breaks the table.
Further switching to black from white or visa versa doesn't work.
image

@github-actions github-actions bot added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: Stylesheets Anything regarding stylesheets/themes labels Aug 18, 2024
@maxwxyz maxwxyz added this to the 1.0 milestone Aug 18, 2024
@chennes
Copy link
Member

chennes commented Sep 13, 2024

@MisterMakerNL is this still planned for 1.0?

@MisterMakerNL
Copy link
Contributor Author

@MisterMakerNL is this still planned for 1.0?

This isn't a simple stylesheet fix if we want too do it properly. We need the same fix as we did with sketches, this is the exact same issue but with tables. Tagging @kadet1090 as I think he also fixed the sketches, although not sure.

@hyarion
Copy link
Contributor

hyarion commented Sep 21, 2024

This isn't a simple stylesheet fix if we want too do it properly. We need the same fix as we did with sketches, this is the exact same issue but with tables. Tagging @kadet1090 as I think he also fixed the sketches, although not sure.

@MisterMakerNL what is the sketch fix you are referring to and why is this the same issue?

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Sep 21, 2024

This isn't a simple stylesheet fix if we want too do it properly. We need the same fix as we did with sketches, this is the exact same issue but with tables. Tagging @kadet1090 as I think he also fixed the sketches, although not sure.

@MisterMakerNL what is the sketch fix you are referring to and why is this the same issue?

With sketch we also had issue that the theme set the sketch color but was stored in the file, and so after switching to another theme the sketch color stayed the same. Now the sketch has a default color that is set by the theme unless the user has applied a custom color.
For spreadsheets we need the same solution. If the user has not touched the color of a cell, it should use a default color that is defined by the theme which is not stored in the file.
And it should always follow the theme, which is an issue with the opentheme fix where it stores this color in the file so it doesn't update after switching themes. I'm tagging @obelisk79 so he knows this.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Oct 29, 2024

any news for this PR?

@hyarion
Copy link
Contributor

hyarion commented Oct 29, 2024

@maxwxyz I think we'll have to postpone this to after 1.0. I don't think it qualifies as a blocker and the fix isn't straight forward.

I think the way to fix this would be to introduce a none-color that can be selected for text and cell color as discussed in: #13862 . This other discussion is put on hold until 1.0 is out.

@maxwxyz maxwxyz modified the milestones: 1.0, Post 1.0 Oct 29, 2024
@luzpaz luzpaz added the Topic: Color Regarding the color handling label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: Color Regarding the color handling Topic: Stylesheets Anything regarding stylesheets/themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants