-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table item text color fix #15937
base: main
Are you sure you want to change the base?
Table item text color fix #15937
Conversation
@MisterMakerNL is this still planned for 1.0? |
This isn't a simple stylesheet fix if we want too do it properly. We need the same fix as we did with sketches, this is the exact same issue but with tables. Tagging @kadet1090 as I think he also fixed the sketches, although not sure. |
@MisterMakerNL what is the sketch fix you are referring to and why is this the same issue? |
With sketch we also had issue that the theme set the sketch color but was stored in the file, and so after switching to another theme the sketch color stayed the same. Now the sketch has a default color that is set by the theme unless the user has applied a custom color. |
any news for this PR? |
@maxwxyz I think we'll have to postpone this to after 1.0. I don't think it qualifies as a blocker and the fix isn't straight forward. I think the way to fix this would be to introduce a none-color that can be selected for text and cell color as discussed in: #13862 . This other discussion is put on hold until 1.0 is out. |
Attempt to fix:
#8168 (comment)
This fix has 2 issues:
If you create a table in a dark-theme, then when you switch to light-theme the text stays white, but the background changes to white and it breaks the table.
Further switching to black from white or visa versa doesn't work.