Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAM: script-style (legacy) postprocessors have a __name__ of "script_module" instead of the postprocessor name #18493

Open
2 tasks done
LarryWoestman opened this issue Dec 14, 2024 · 1 comment · May be fixed by #18538
Open
2 tasks done

CAM: script-style (legacy) postprocessors have a __name__ of "script_module" instead of the postprocessor name #18493

LarryWoestman opened this issue Dec 14, 2024 · 1 comment · May be fixed by #18538
Assignees
@LarryWoestman
Labels
Mod: CAM Related to the CAM/Path Workbench Status: Confirmed The issue was confirmed by others Type: Bug This issue or PR is related to a bug Type: Regression Bugs describing a regression or PRs fixing one

Comments

@LarryWoestman
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Script-style (legacy) postprocessors have a name of "script_module" instead of the postprocessor name. This value shows up in a comment in the generated g-code for most postprocessors. This causes confusion for the users of the postprocessors since they are seeing an incorrect postprocessor name.

This is a regression caused by the newer, more object-oriented postprocessor execution code in the CAM workbench. I have already figured out the fix and will be posting a PR for this issue soon.

Please assign this issue to me.

Full version info

OS: Windows 11 build 22631
Architecture: x86_64
Version: 1.1.0dev.39333 (Git)
Build type: Release
Branch: main
Hash: 6860aab7ee7d8a3642c0a69a4c96883eb7253c18
Python 3.12.4, Qt 6.7.2, Coin 4.0.2, Vtk 9.3.0, OCC 7.8.0
Locale: English/United States (en_US)
Stylesheet/Theme/QtStyle: FreeCAD Dark.qss/FreeCAD Dark/

Subproject(s) affected?

CAM

Anything else?

https://forum.freecad.org/viewtopic.php?t=92947

Code of Conduct

  • I agree to follow this project's Code of Conduct
@LarryWoestman LarryWoestman added Status: Needs confirmation Missing confirmation from other testers Status: Needs triage Missing triage labels Dec 14, 2024
@maxwxyz maxwxyz added Type: Bug This issue or PR is related to a bug Mod: CAM Related to the CAM/Path Workbench Type: Regression Bugs describing a regression or PRs fixing one Status: Confirmed The issue was confirmed by others and removed Status: Needs confirmation Missing confirmation from other testers Status: Needs triage Missing triage labels Dec 14, 2024
@luzpaz luzpaz changed the title CAM: script-style (legacy) postprocessors have a __name__ of "script_module" instead of the postprocessor name CAM: script-style (legacy) postprocessors have a __name__ of "script_module" instead of the postprocessor name Dec 14, 2024
@github-actions github-actions bot mentioned this issue Dec 15, 2024
Closed
@LarryWoestman LarryWoestman linked a pull request Dec 15, 2024 that will close this issue
Open
@LarryWoestman
Copy link
Contributor Author

PR #18538 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LarryWoestman LarryWoestman

Labels
Mod: CAM Related to the CAM/Path Workbench Status: Confirmed The issue was confirmed by others Type: Bug This issue or PR is related to a bug Type: Regression Bugs describing a regression or PRs fixing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CAM: Fixed script-style postprocessors getting the wrong __name__ LarryWoestman/FreeCAD
2 participants
@maxwxyz @LarryWoestman