Remove the deprecated babel-plugin-lodash (#2965)

FormidableLabs · Nov 13, 2024 · e4514a6 · e4514a6
1 parent 7eafe76
commit e4514a6
Show file tree

Hide file tree

Showing 81 changed files with 210 additions and 117 deletions.
diff --git a/.babelrc.js b/.babelrc.js
@@ -18,7 +18,6 @@ module.exports = {
     "@babel/preset-react",
     "@babel/preset-typescript",
   ],
-  plugins: ["lodash"],
   ignore: ["**/*.d.ts"],
   env: {
     commonjs: {

diff --git a/.changeset/lucky-pots-double.md b/.changeset/lucky-pots-double.md
@@ -0,0 +1,29 @@
+---
+"victory-area": patch
+"victory-axis": patch
+"victory-bar": patch
+"victory-box-plot": patch
+"victory-brush-container": patch
+"victory-brush-line": patch
+"victory-candlestick": patch
+"victory-chart": patch
+"victory-core": patch
+"victory-create-container": patch
+"victory-cursor-container": patch
+"victory-errorbar": patch
+"victory-group": patch
+"victory-legend": patch
+"victory-line": patch
+"victory-native": patch
+"victory-pie": patch
+"victory-polar-axis": patch
+"victory-selection-container": patch
+"victory-shared-events": patch
+"victory-stack": patch
+"victory-tooltip": patch
+"victory-voronoi": patch
+"victory-voronoi-container": patch
+"victory-zoom-container": patch
+---
+
+Remove deprecated babel-plugin-lodash plugin
diff --git a/demo/ts/components/accessibility-demo.tsx b/demo/ts/components/accessibility-demo.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { isNumber } from "lodash";
+import isNumber from "lodash/isNumber";
 import { VictoryGroup } from "victory-group";
 import { VictoryStack } from "victory-stack";
 import { VictoryChart } from "victory-chart";

diff --git a/demo/ts/components/create-container-demo.tsx b/demo/ts/components/create-container-demo.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { round } from "lodash";
+import round from "lodash/round";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";
 import { VictoryGroup } from "victory-group";

diff --git a/demo/ts/components/external-events-demo.tsx b/demo/ts/components/external-events-demo.tsx
@@ -6,7 +6,7 @@ import { VictoryBar } from "victory-bar";
 import { VictoryLine } from "victory-line";
 import { VictoryZoomContainer } from "victory-zoom-container";
 import { VictoryVoronoiContainer } from "victory-voronoi-container";
-import { range } from "lodash";
+import range from "lodash/range";
 import { VictoryTheme, VictoryThemePalette } from "victory-core";
 
 const themeColors: VictoryThemePalette =

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -16,10 +16,12 @@ export default tseslint.config(
     ignores: [
       "**/*.d.ts",
       "**/.wireit/",
+      "**/.docusaurus/",
       "**/artifacts/",
       "**/coverage/",
       "**/demo/rn/",
       "**/dist/",
+      "**/build/",
       "**/es/",
       "**/lib/",
       "**/lib-vendor/",
@@ -77,6 +79,13 @@ export default tseslint.config(
       "no-restricted-imports": [
         "error",
         {
+          paths: [
+            {
+              name: "lodash",
+              message:
+                "Be sure to import specific lodash functions, not the entire library!",
+            },
+          ],
           patterns: [
             {
               group: ["victory*/src", "victory*/src/**"],
@@ -133,6 +142,7 @@ export default tseslint.config(
     files: ["**/demo/**/*.{ts,tsx}"],
     rules: {
       "no-magic-numbers": "off",
+      "no-restricted-imports": "off",
       "react/no-multi-comp": "off",
       "@typescript-eslint/no-empty-object-type": "off",
     },

diff --git a/package.json b/package.json
@@ -57,7 +57,6 @@
     "autoprefixer": "^10.0.1",
     "babel-jest": "29.7.0",
     "babel-loader": "9.1.3",
-    "babel-plugin-lodash": "3.3.4",
     "babel-plugin-module-resolver": "5.0.0",
     "babel-preset-react-native": "4.0.1",
     "chromatic": "^11.16.3",

diff --git a/packages/victory-area/src/area.tsx b/packages/victory-area/src/area.tsx
@@ -1,6 +1,6 @@
 /* eslint no-magic-numbers: ["error", { "ignore": [-1, 0, 1, 2] }]*/
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 import * as d3Shape from "victory-vendor/d3-shape";
 import {
   Helpers,

diff --git a/packages/victory-axis/src/helper-methods.tsx b/packages/victory-axis/src/helper-methods.tsx
@@ -1,4 +1,4 @@
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 import { Helpers, Scale, Axis } from "victory-core";
 import { VictoryAxisProps } from "./victory-axis";
 

diff --git a/packages/victory-axis/src/victory-axis.tsx b/packages/victory-axis/src/victory-axis.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { isEmpty } from "lodash";
+import isEmpty from "lodash/isEmpty";
 import {
   VictoryLabel,
   VictoryContainer,

diff --git a/packages/victory-bar/src/bar-helper-methods.ts b/packages/victory-bar/src/bar-helper-methods.ts
@@ -1,4 +1,4 @@
-import { isPlainObject } from "lodash";
+import isPlainObject from "lodash/isPlainObject";
 import { Helpers, VictoryStyleObject } from "victory-core";
 import { BarProps } from "./bar";
 import {

diff --git a/packages/victory-bar/src/bar.tsx b/packages/victory-bar/src/bar.tsx
@@ -1,5 +1,5 @@
 import React, { forwardRef } from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 import {
   Helpers,
   NumberOrCallback,

diff --git a/packages/victory-box-plot/src/helper-methods.tsx b/packages/victory-box-plot/src/helper-methods.tsx
@@ -1,4 +1,8 @@
-import { orderBy, defaults, uniq, groupBy } from "lodash";
+import defaults from "lodash/defaults";
+import groupBy from "lodash/groupBy";
+import orderBy from "lodash/orderBy";
+import uniq from "lodash/uniq";
+
 import { Helpers, Scale, Domain, Data, Collection } from "victory-core";
 import {
   min as d3Min,

diff --git a/packages/victory-brush-container/src/brush-helpers.ts b/packages/victory-brush-container/src/brush-helpers.ts
@@ -1,5 +1,7 @@
+import defaults from "lodash/defaults";
+import throttle from "lodash/throttle";
+
 import { Helpers as CoreHelpers, Selection } from "victory-core";
-import { throttle, defaults } from "lodash";
 import isEqual from "react-fast-compare";
 
 const Helpers = {

diff --git a/packages/victory-brush-container/src/victory-brush-container.tsx b/packages/victory-brush-container/src/victory-brush-container.tsx
@@ -8,7 +8,7 @@ import {
   VictoryEventHandler,
 } from "victory-core";
 import { BrushHelpers } from "./brush-helpers";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 import isEqual from "react-fast-compare";
 
 export interface VictoryBrushContainerProps extends VictoryContainerProps {

diff --git a/packages/victory-brush-line/src/victory-brush-line.tsx b/packages/victory-brush-line/src/victory-brush-line.tsx
@@ -1,4 +1,7 @@
 import React from "react";
+import defaults from "lodash/defaults";
+import pick from "lodash/pick";
+
 import {
   Selection,
   Helpers,
@@ -10,7 +13,6 @@ import {
   DomainTuple,
   VictoryStyleObject,
 } from "victory-core";
-import { defaults, pick } from "lodash";
 import isEqual from "react-fast-compare";
 
 export type VictoryBrushLineTargetType = "data" | "labels" | "parent";

diff --git a/packages/victory-candlestick/src/candle.tsx b/packages/victory-candlestick/src/candle.tsx
@@ -7,7 +7,7 @@ import {
   VictoryCommonPrimitiveProps,
   VictoryStyleObject,
 } from "victory-core";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 export interface CandleProps extends VictoryCommonPrimitiveProps {
   candleRatio?: number;

diff --git a/packages/victory-candlestick/src/helper-methods.ts b/packages/victory-candlestick/src/helper-methods.ts
@@ -1,4 +1,6 @@
-import { defaults, isPlainObject } from "lodash";
+import defaults from "lodash/defaults";
+import isPlainObject from "lodash/isPlainObject";
+
 import {
   Helpers,
   Scale,

diff --git a/packages/victory-chart/src/helper-methods.tsx b/packages/victory-chart/src/helper-methods.tsx
@@ -1,6 +1,6 @@
 import React from "react";
 import { Helpers, Scale, Axis, Wrapper } from "victory-core";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 const fallbackProps = {
   width: 450,

diff --git a/packages/victory-chart/src/victory-chart.tsx b/packages/victory-chart/src/victory-chart.tsx
@@ -1,5 +1,7 @@
-import { defaults, isEmpty } from "lodash";
 import React from "react";
+import defaults from "lodash/defaults";
+import isEmpty from "lodash/isEmpty";
+
 import {
   Background,
   Helpers,

diff --git a/packages/victory-core/src/exports.test.ts b/packages/victory-core/src/exports.test.ts
@@ -142,7 +142,7 @@ import {
   mergeRefs,
   usePortalContext,
 } from "./index";
-import { pick } from "lodash";
+import pick from "lodash/pick";
 
 describe("victory-core", () => {
   it("exports addEvents", () => {

diff --git a/packages/victory-core/src/victory-animation/util.ts b/packages/victory-core/src/victory-animation/util.ts
@@ -1,5 +1,7 @@
+import isPlainObject from "lodash/isPlainObject";
+import orderBy from "lodash/orderBy";
+
 import { interpolate } from "victory-vendor/d3-interpolate";
-import { isPlainObject, orderBy } from "lodash";
 
 export const isInterpolatable = function (obj) {
   // d3 turns null into 0 and undefined into NaN, which we don't want.

diff --git a/packages/victory-core/src/victory-clip-container/victory-clip-container.tsx b/packages/victory-core/src/victory-clip-container/victory-clip-container.tsx
@@ -1,7 +1,10 @@
 import React from "react";
+import defaults from "lodash/defaults";
+import isObject from "lodash/isObject";
+import uniqueId from "lodash/uniqueId";
+
 import * as Helpers from "../victory-util/helpers";
 import * as UserProps from "../victory-util/user-props";
-import { defaults, isObject, uniqueId } from "lodash";
 import { ClipPath } from "../victory-primitives/clip-path";
 import { Circle } from "../victory-primitives/circle";
 import { Rect } from "../victory-primitives/rect";

diff --git a/packages/victory-core/src/victory-container/victory-container.tsx b/packages/victory-core/src/victory-container/victory-container.tsx
@@ -1,5 +1,5 @@
 import React, { useRef } from "react";
-import { uniqueId } from "lodash";
+import uniqueId from "lodash/uniqueId";
 import { Portal } from "../victory-portal/portal";
 import * as UserProps from "../victory-util/user-props";
 import { OriginType } from "../victory-label/victory-label";

diff --git a/packages/victory-core/src/victory-label/victory-label.tsx b/packages/victory-core/src/victory-label/victory-label.tsx
@@ -1,6 +1,8 @@
 /* eslint no-magic-numbers: ["error", { "ignore": [-0.5, 0.5, 0, 1, 2] }]*/
-import { defaults, isEmpty } from "lodash";
 import React from "react";
+import defaults from "lodash/defaults";
+import isEmpty from "lodash/isEmpty";
+
 import { VictoryPortal } from "../victory-portal/victory-portal";
 import { Rect } from "../victory-primitives/rect";
 import { Text } from "../victory-primitives/text";

diff --git a/packages/victory-core/src/victory-portal/victory-portal.tsx b/packages/victory-core/src/victory-portal/victory-portal.tsx
@@ -1,5 +1,7 @@
 import React, { useState } from "react";
-import { defaults, uniqueId } from "lodash";
+import defaults from "lodash/defaults";
+import uniqueId from "lodash/uniqueId";
+
 import * as Log from "../victory-util/log";
 import * as Helpers from "../victory-util/helpers";
 import { usePortalContext } from "./portal-context";

diff --git a/packages/victory-core/src/victory-primitives/arc.tsx b/packages/victory-core/src/victory-primitives/arc.tsx
@@ -1,6 +1,6 @@
 /* eslint no-magic-numbers: ["error", { "ignore": [0, 1, 2, 180] }]*/
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

diff --git a/packages/victory-core/src/victory-primitives/background.tsx b/packages/victory-core/src/victory-primitives/background.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

diff --git a/packages/victory-core/src/victory-primitives/border.tsx b/packages/victory-core/src/victory-primitives/border.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

diff --git a/packages/victory-core/src/victory-primitives/line-segment.tsx b/packages/victory-core/src/victory-primitives/line-segment.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

diff --git a/packages/victory-core/src/victory-primitives/point.tsx b/packages/victory-core/src/victory-primitives/point.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import * as pathHelpers from "../victory-util/point-path-helpers";

diff --git a/packages/victory-core/src/victory-primitives/whisker.tsx b/packages/victory-core/src/victory-primitives/whisker.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

diff --git a/packages/victory-core/src/victory-transition/victory-transition.tsx b/packages/victory-core/src/victory-transition/victory-transition.tsx
@@ -1,11 +1,13 @@
 import React from "react";
+import defaults from "lodash/defaults";
+import pick from "lodash/pick";
+import isEqual from "react-fast-compare";
+
 import { VictoryAnimation } from "../victory-animation/victory-animation";
 import * as Collection from "../victory-util/collection";
 import * as Helpers from "../victory-util/helpers";
 import TimerContext from "../victory-util/timer-context";
 import * as Transitions from "../victory-util/transitions";
-import { defaults, pick } from "lodash";
-import isEqual from "react-fast-compare";
 import Timer from "../victory-util/timer";
 
 type VictoryTransitionChild = React.ReactElement<

diff --git a/packages/victory-core/src/victory-util/add-events.tsx b/packages/victory-core/src/victory-util/add-events.tsx
@@ -1,5 +1,8 @@
 import React from "react";
-import { defaults, isEmpty, pick } from "lodash";
+import defaults from "lodash/defaults";
+import isEmpty from "lodash/isEmpty";
+import pick from "lodash/pick";
+
 import isEqual from "react-fast-compare";
 
 import { VictoryLabelableProps } from "../types/prop-types";

diff --git a/packages/victory-core/src/victory-util/axis.tsx b/packages/victory-core/src/victory-util/axis.tsx
@@ -1,5 +1,9 @@
 import React from "react";
-import { defaults, isObject, uniq, orderBy } from "lodash";
+import defaults from "lodash/defaults";
+import isObject from "lodash/isObject";
+import uniq from "lodash/uniq";
+import orderBy from "lodash/orderBy";
+
 import * as Collection from "./collection";
 import * as Domain from "./domain";
 import * as Helpers from "./helpers";

diff --git a/packages/victory-core/src/victory-util/data.ts b/packages/victory-core/src/victory-util/data.ts
@@ -1,14 +1,13 @@
 import React from "react";
-import {
-  uniq,
-  isPlainObject,
-  property,
-  orderBy,
-  isEmpty,
-  isEqual,
-  isUndefined,
-  omitBy,
-} from "lodash";
+import isEmpty from "lodash/isEmpty";
+import isEqual from "lodash/isEqual";
+import isPlainObject from "lodash/isPlainObject";
+import isUndefined from "lodash/isUndefined";
+import omitBy from "lodash/omitBy";
+import orderBy from "lodash/orderBy";
+import property from "lodash/property";
+import uniq from "lodash/uniq";
+
 import * as Helpers from "./helpers";
 import * as Collection from "./collection";
 import * as Scale from "./scale";

diff --git a/packages/victory-core/src/victory-util/domain.ts b/packages/victory-core/src/victory-util/domain.ts
@@ -1,5 +1,8 @@
 import React from "react";
-import { isPlainObject, sortedUniq, isDate } from "lodash";
+import isDate from "lodash/isDate";
+import isPlainObject from "lodash/isPlainObject";
+import sortedUniq from "lodash/sortedUniq";
+
 import * as Data from "./data";
 import * as Scale from "./scale";
 import * as Helpers from "./helpers";

diff --git a/packages/victory-core/src/victory-util/events.ts b/packages/victory-core/src/victory-util/events.ts
@@ -1,6 +1,9 @@
 import React from "react";
+import isEmpty from "lodash/isEmpty";
+import pickBy from "lodash/pickBy";
+import omitBy from "lodash/omitBy";
+import uniq from "lodash/uniq";
 
-import { isEmpty, pickBy, omitBy, uniq } from "lodash";
 import type { EventMixinCalculatedValues } from "./add-events";
 import { isFunction } from "./helpers";