forked from pulsar-edit/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added ADR to describe pathwatcher removal try
- Loading branch information
1 parent
0a18f99
commit eeacfeb
Showing
1 changed file
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
--- | ||
status: rejected | ||
--- | ||
# Make a compatibility layer on Pulsar's "pathwatcher" | ||
|
||
## Remove the binary dependency on "pathwatcher" and a compatibility layer to use Pulsar's public API | ||
|
||
The idea was to keep 100% API compatibility with Pathwatcher using Pulsar's public API (using `require('atom').watchPath` code). The experiment lives on [Pulsar | ||
Pathwatcher](https://github.com/pulsar-edit/pulsar-pathwatcher) repository | ||
|
||
## Decision Drivers | ||
|
||
* Avoid another watch library | ||
* Avoid another binary dependency | ||
|
||
## Decision Outcome | ||
|
||
Because of the cyclic dependency between TextBuffer and Pulsar, together with | ||
the "exports" library and other issues, this experiment didn't go far. Some | ||
infinite loops happened, sometimes the renderer process crashed, and sometimes | ||
other weird issues appeared depending on the order things got loaded, so | ||
this will probably be revisited in the future, if at all. |