[FEATURE] Context view helpers #735
Conversation
| * GNU General Public License for more details. | ||
| * This copyright notice MUST APPEAR in all copies of the script! | ||
| * ************************************************************* */ | ||
| use TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper; |
There was a problem hiding this comment.
Missing line break here between file header and imports; here and in following classes. Note to self: needs a php code sniffer sniff!
|
Hi Benjamin - very good stuff, these definitely have a use! Apart from the code style things I noted inline, I'd like the |
|
PS: don't mind the failing Travis build, your code looks fine ;) |
|
Sorry, missed your Q regarding minimum TYPO3 version - we already have a couple of those and are planning to make 6.2 the minimum requirement in a very short time also for VHS, so this is not an issue. |
BenjaminBeck
force-pushed
the
FEATURE_Context_view_helpers
branch
from
2f1afde to
f042f4b
Compare
|
👍 |
BenjaminBeck
force-pushed
the
FEATURE_Context_view_helpers
branch
from
4968a12 to
982020c
Compare
|
Hi NamelessCoder, thank for reviewing. The issues are corrected now. I will squash the commits once everything is fine. |
Perfect, we like squash ;)
Unit tests would be the icing on the cake! If you add those before you squash, A+ :) |
This is an automated comment based on an automated formal commit review.Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it! |
| /** | ||
| * @test | ||
| */ | ||
| public function renderCompleteContext (){ |
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
This is an automated comment based on an automated formal commit review.Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it! |
1 similar comment
This is an automated comment based on an automated formal commit review.Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it! |
BenjaminBeck
force-pushed
the
FEATURE_Context_view_helpers
branch
from
ba231c3 to
7c3cf96
Compare
BenjaminBeck
force-pushed
the
FEATURE_Context_view_helpers
branch
from
7c3cf96 to
bacde17
Compare
|
From my side it´s ready to merge. |
[FEATURE] Context view helpers
With this view-helpers you can use the
TYPO3_CONTEXTto output different content for your development,testing or production environment.Please don´t merge until the following questions are solved:
TYPO3_CONTEXTgot added in 6.2 but vhs emconf says 6.0 is supported - how do we deal with that old versions? Can we have view-helpers that only work with 6.2?ViewHelpers/Context/*. I used the wording "Context" because the core uses it, although "Environment" would feel more intuitive to me. There are also already some view-helpers in a similar namespace:ViewHelpers/Condition/Context/*. I am open for suggestions to improve this situation.