-
Notifications
You must be signed in to change notification settings - Fork 217
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Restore label generation for Form-level element
- Loading branch information
1 parent
27d5d81
commit 41cb134
Showing
2 changed files
with
6 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41cb134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NamelessCoder ,
I'm not really aware of the reason behind this change or what restoring means in this context, but I think this will break a lot of labels for forms. Because in the current documentation of the label attribute for <flux:form ../> states that an identifier in the form flux.formId will be looked up if none is given explicitly.
With this change a guessed label will have to be in the form flux.**form.**formId. I noticed that in my current project after I updated to the latest version of the development branch where all my form labels were gone because I sticked to the current documentation. Which I also did in every other project in the past. And I guess I'm not the only one ;-)
So if there will be made an update to the next release version all forms (and page layouts of course) will sit there with no name having only a description.
Am I totally wrong here or missing something?
41cb134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tpinne, @NamelessCoder
This is a breaking change!
All labels in the existing language files must be updated.
As @tpinne has described, This change will cause many problems ...
41cb134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're both right guys - would you mind preparing a PR to follow up on this? I'm a little short on time these days.
41cb134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tpinne, @NamelessCoder
I have prepared a PR. #1123