Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtask input plugin #2478

Merged
merged 13 commits into from
Dec 22, 2019
Merged

Add subtask input plugin #2478

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0fbc23f
Add subtask input plugin.
gazpachoking Nov 5, 2019
4ab6be8
Simplify how seen plugin gets disabled a bit in subtasks.
gazpachoking Nov 7, 2019
8bc2c03
Don't pass task options through to subtasks.
gazpachoking Nov 7, 2019
be3fe8c
Add basic subtask test
gazpachoking Nov 7, 2019
3d9059c
Verify seen behavior in subtask test.
gazpachoking Nov 7, 2019
260eedc
Remove 5 minute caching on subtask.
gazpachoking Dec 13, 2019
162b591
Merge branch 'develop' into subtask_input
gazpachoking Dec 20, 2019
dd4de36
Update subtask plugin for logging changes
gazpachoking Dec 20, 2019
90e76d2
Finish updating subtask plugin for logging changes
gazpachoking Dec 20, 2019
dfea817
Rename subtask->from_task
gazpachoking Dec 20, 2019
66f9de4
Really finish logging changes in from_task
gazpachoking Dec 20, 2019
839ea05
Update tests for subtask->from_task rename
gazpachoking Dec 20, 2019
42d7c00
Manual tasks can be executed via from_task
gazpachoking Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify how seen plugin gets disabled a bit in subtasks. 
Change subtask name to use > instead of .
  • Loading branch information
@gazpachoking
gazpachoking committed Nov 7, 2019
commit 4ab6be86c7adc25949bdbcb6c65836f5d98469f2
9 changes: 3 additions & 6 deletions flexget/plugins/input/subtask.py
View file
Original file line number Diff line number Diff line change
@@ -22,14 +22,11 @@ class Subtask(object):
def on_task_input(self, task, config):
subtask_name = config
subtask_config = task.manager.config['tasks'].get(subtask_name, {})
# TODO: This seen disabling is super hacky, is there a better way?
if 'seen' not in subtask_config:
if isinstance(subtask_config.get('disable'), str):
subtask_config['disable'] = [subtask_config['disable']]
subtask_config.setdefault('disable', []).append('seen')
# TODO: This seen disabling is sorta hacky, is there a better way?
subtask_config.setdefault('seen', False)
input_task = Task(
task.manager,
'{}.{}'.format(task.name, subtask_name),
'{}>{}'.format(task.name, subtask_name),
config=subtask_config,
# TODO: Do we want to pass all options through? Things like inject don't make sense, but perhaps others do.
options=task.options,