Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import path UI and button to open folder in asset import settings. #3128

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

Tryibion
Copy link
Member

Adds import path (non-editable) and button to open the import folder for each asset type

image

@xxSeys1
Copy link
Contributor

xxSeys1 commented Dec 31, 2024

This is super cool, but one issue I can see is people getting confused because they can't edit the import path. I don't have much experience with Flax text rendering, but is there a way to maybe grey out the path slightly to make it more obvious that it can't be edited?

Right now the white text suggests that the text is editable in my opinion.

@Tryibion
Copy link
Member Author

Tryibion commented Dec 31, 2024

maybe. the disabled text color is the text color * 0.6f to be more grey. I guess we could do something inbetween for read only. maybe textcolor * 0.85f? it would look like this:
image

@Tryibion
Copy link
Member Author

I added the color change to a different PR here #3129

@mafiesto4 mafiesto4 added enhancement New feature or request editor content Game content and assets labels Jan 6, 2025
@mafiesto4 mafiesto4 added this to the 1.10 milestone Jan 6, 2025
Copy link
Member

@mafiesto4 mafiesto4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a utility method in FlaxEditor.Utilities.Utils to reuse in different windows and reduce code duplication.

Also, you could try changing button text to FlaxEditor.Utilities.Constants.ShowInExplorer so it uses Finder name on Mac.

@Tryibion
Copy link
Member Author

Tryibion commented Jan 6, 2025

Please, add a utility method in FlaxEditor.Utilities.Utils to reuse in different windows and reduce code duplication.

Done.

@Tryibion Tryibion requested a review from mafiesto4 January 6, 2025 22:00
@flaxtechnology flaxtechnology merged commit 5335594 into FlaxEngine:master Jan 6, 2025
11 checks passed
@Tryibion Tryibion deleted the import-path-ui branch January 7, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Game content and assets editor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants