feat: bump minimum node version to 12.x (projen#1113)

FitX · Oct 4, 2021 · b493fac · b493fac
1 parent 903610f
commit b493fac
Show file tree

Hide file tree

Showing 14 changed files with 117 additions and 53 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
diff --git a/.github/workflows/upgrade-main.yml b/.github/workflows/upgrade-main.yml
diff --git a/.projen/deps.json b/.projen/deps.json
diff --git a/.projenrc.js b/.projenrc.js
@@ -41,7 +41,7 @@ const project = new JsiiProject({
 
   projenDevDependency: false, // because I am projen
   releaseToNpm: true,
-  minNodeVersion: '10.17.0',
+  minNodeVersion: '12.7.0',
   codeCov: true,
   defaultReleaseBranch: 'main',
   gitpod: true,

diff --git a/package.json b/package.json
diff --git a/src/__tests__/__snapshots__/integ.test.ts.snap b/src/__tests__/__snapshots__/integ.test.ts.snap
diff --git a/src/__tests__/__snapshots__/jsii.test.ts.snap b/src/__tests__/__snapshots__/jsii.test.ts.snap
diff --git a/src/__tests__/integration/cdk8s/cdk8s.common.js b/src/__tests__/integration/cdk8s/cdk8s.common.js
@@ -1,5 +1,5 @@
 exports.options = {
-  minNodeVersion: '10.17.0',
+  minNodeVersion: '12.7.0',
   repository: 'https://github.com/awslabs/cdk8s.git',
   authorName: 'Amazon Web Services',
   authorUrl: 'https://aws.amazon.com',

diff --git a/src/__tests__/jsii.test.ts b/src/__tests__/jsii.test.ts
@@ -291,6 +291,45 @@ test('docgen: true should just work', () => {
   expect(output['.projen/tasks.json'].tasks.docgen.steps[0].exec).toStrictEqual('jsii-docgen');
 });
 
+describe('superchain image is selected based on the node version', () => {
+  const opts = {
+    author: 'My name',
+    name: 'testproject',
+    authorAddress: 'https://foo.bar',
+    defaultReleaseBranch: 'main',
+    repositoryUrl: 'https://github.com/foo/bar.git',
+  };
+
+  test('defaults to 1-buster-slim without minNodeVersion', () => {
+    const project = new TestJsiiProject(opts);
+    const output = synthSnapshot(project);
+    expect(output['.github/workflows/build.yml']).toContain('image: jsii/superchain:1-buster-slim');
+  });
+
+  test('12.x', () => {
+    const project = new TestJsiiProject({ ...opts, minNodeVersion: '12.22.1' });
+    const output = synthSnapshot(project);
+    expect(output['.github/workflows/build.yml']).toContain('image: jsii/superchain:1-buster-slim-node12');
+  });
+
+  test('14.x', () => {
+    const project = new TestJsiiProject({ ...opts, minNodeVersion: '14.42.1' });
+    const output = synthSnapshot(project);
+    expect(output['.github/workflows/build.yml']).toContain('image: jsii/superchain:1-buster-slim-node14');
+  });
+
+  test('16.x', () => {
+    const project = new TestJsiiProject({ ...opts, minNodeVersion: '16.22.1' });
+    const output = synthSnapshot(project);
+    expect(output['.github/workflows/build.yml']).toContain('image: jsii/superchain:1-buster-slim-node16');
+  });
+
+  test('unsupported version', () => {
+    expect(() => new TestJsiiProject({ ...opts, minNodeVersion: '15.3.20' })).toThrow('No jsii/superchain image available for node 15.x. Supported node versions: 12.x,14.x,16.x');
+    expect(() => new TestJsiiProject({ ...opts, minNodeVersion: '10.2.3' })).toThrow('No jsii/superchain image available for node 10.x. Supported node versions: 12.x,14.x,16.x');
+  });
+});
+
 class TestJsiiProject extends JsiiProject {
   constructor(options: JsiiProjectOptions) {
     super({