fix: no-floating-promises (projen#1628)

Using `yarn eslint` I noticed a rule break defined here https://github.com/projen/projen/blob/main/.eslintrc.json#L95 https://typescript-eslint.io/rules/no-floating-promises/ ``` Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator.eslint[@typescript-eslint/no-floating-promises](https://typescript-eslint.io/rules/no-floating-promises) ``` --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
FitX · Feb 21, 2022 · 2d08e72 · 2d08e72
1 parent 164c959
commit 2d08e72
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 24 deletions.
diff --git a/src/web/react.ts b/src/web/react.ts
@@ -429,15 +429,18 @@ class ReactSampleCode extends Component {
       "",
       "const reportWebVitals = (onPerfEntry?: ReportHandler) => {",
       "  if (onPerfEntry && onPerfEntry instanceof Function) {",
-      "    import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {",
-      "      getCLS(onPerfEntry);",
-      "      getFID(onPerfEntry);",
-      "      getFCP(onPerfEntry);",
-      "      getLCP(onPerfEntry);",
-      "      getTTFB(onPerfEntry);",
-      "    });",
+      "    import('web-vitals').then(",
+      "      ({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {",
+      "        getCLS(onPerfEntry);",
+      "        getFID(onPerfEntry);",
+      "        getFCP(onPerfEntry);",
+      "        getLCP(onPerfEntry);",
+      "        getTTFB(onPerfEntry);",
+      "      },",
+      "      () => {}",
+      "    );",
       "  }",
-      "}",
+      "};",
       "",
       "export default reportWebVitals;",
     ];

diff --git a/test/web/__snapshots__/react-project.test.ts.snap b/test/web/__snapshots__/react-project.test.ts.snap
diff --git a/test/web/__snapshots__/react-ts-project.test.ts.snap b/test/web/__snapshots__/react-ts-project.test.ts.snap