Skip to content

Commit

Permalink
fix: require node.js ^12.7.0 instead of ^12.13.0 (projen#1122)
Browse files Browse the repository at this point in the history
The latest projen release bumped the minimum node.js version requirement to ^12.13.0 but this is technically a breaking change and blocks upgrades for projects that execute workflows against 12.7.0 (such as `constructs`).

This change reverts the minimum node engine version to 12.7.0 while still running our workflows against 12.13.0, which is required by `jest`. This is not perfectly correct as it means projen may depend on functionality that does not exist in 12.7.0 but its pragmatic and will cause less grief.

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
Elad Ben-Israel authored Oct 7, 2021
1 parent e2d12ca commit 160dad4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion .projenrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ const project = new JsiiProject({

projenDevDependency: false, // because I am projen
releaseToNpm: true,
minNodeVersion: '12.13.0',
minNodeVersion: '12.7.0',
workflowNodeVersion: '12.13.0', // required by jest

codeCov: true,
defaultReleaseBranch: 'main',
gitpod: true,
Expand Down
4 changes: 2 additions & 2 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 160dad4

Please sign in to comment.