Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCRAM tests #738

Merged
merged 64 commits into from
Jan 29, 2024
Merged

Add SCRAM tests #738

merged 64 commits into from
Jan 29, 2024

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jan 16, 2024

Closes #681.

MongoDB is now configured with authorization enabled by default using a keyfile, so that we can have a single environment. And it's easier than generating x.509 certs and using TLS.

Not enabling authorization yet as it's not needed to verify credentials.

@b1ron b1ron added the code/chore Dance tool code maintenance improvements label Jan 16, 2024
@b1ron b1ron self-assigned this Jan 16, 2024
@b1ron b1ron requested a review from AlekSi January 22, 2024 18:16
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FerretDB/FerretDB#3996 was merged, CI restarted – and a bunch of tests still fail

@b1ron b1ron requested a review from AlekSi January 24, 2024 09:31
.github/workflows/dance.yml Outdated Show resolved Hide resolved
Taskfile.yaml Outdated Show resolved Hide resolved
build/mongod.conf Outdated Show resolved Hide resolved
@b1ron
Copy link
Contributor Author

b1ron commented Jan 24, 2024

I just noticed a bug here in the comparison switch statement that I introduced. I will fix it in a separate PR.

:|

@b1ron b1ron requested a review from AlekSi January 24, 2024 14:36
internal/config/config.go Outdated Show resolved Hide resolved
@b1ron b1ron requested a review from AlekSi January 24, 2024 15:28
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

Copy link
Contributor

mergify bot commented Jan 29, 2024

@b1ron this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jan 29, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jan 29, 2024
@b1ron b1ron requested a review from AlekSi January 29, 2024 11:58
@b1ron b1ron merged commit dafd423 into FerretDB:main Jan 29, 2024
75 checks passed
@b1ron b1ron deleted the scram branch January 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Dance tool code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add tests for SCRAM-SHA-1 and SCRAM-SHA-256
2 participants