Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak linter settings #942

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Tweak linter settings #942

merged 2 commits into from
Jul 26, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 26, 2022

Description

Complements #928.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 26, 2022
@AlekSi AlekSi added this to the v0.5.1 milestone Jul 26, 2022
@AlekSi AlekSi self-assigned this Jul 26, 2022
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva and noisersup and removed request for a team July 26, 2022 06:21
@AlekSi AlekSi enabled auto-merge (squash) July 26, 2022 06:21
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #942 (6998c9e) into main (4446f44) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   62.54%   62.60%   +0.05%     
==========================================
  Files         225      225              
  Lines       10444    10444              
==========================================
+ Hits         6532     6538       +6     
+ Misses       3141     3134       -7     
- Partials      771      772       +1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/collections.go 60.17% <0.00%> (+5.30%) ⬆️
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
Flag Coverage Δ
integration 57.47% <ø> (ø)
mongodb 18.82% <ø> (-0.02%) ⬇️
pg 62.41% <ø> (ø)
tigris 18.50% <ø> (-0.03%) ⬇️
unit 24.55% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a helpful linter! I haven't seen it before.

@AlekSi AlekSi merged commit c0fa49b into FerretDB:main Jul 26, 2022
@AlekSi AlekSi deleted the linters branch July 26, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants