Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MsgCount for Tigris #928

Merged
merged 22 commits into from
Jul 26, 2022
Merged

Implement MsgCount for Tigris #928

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6955ff2
start counting cycle time
Jul 21, 2022
49238aa
Add lazy implementation
Jul 21, 2022
dc192d9
Merge branch 'main' into issue-771-msg-count
rumyantseva Jul 21, 2022
ca7002a
Tigris MsgCounta and simple smoke tests
Jul 21, 2022
f978c28
Merge branch 'issue-771-msg-count' of github.com:rumyantseva/FerretDB…
Jul 21, 2022
bfd3a6d
Merge branch 'main' into issue-771-msg-count
rumyantseva Jul 21, 2022
d2aea46
Temporary commit beautiful impossible code
Jul 21, 2022
8ab8780
Handle errors through GRPC codes
Jul 21, 2022
e6ce18d
Merge branch 'main' into issue-771-msg-count
rumyantseva Jul 21, 2022
7ca6e05
linters
Jul 21, 2022
92bbd9e
No need for grpc
Jul 21, 2022
ef9bfa9
liners for tigris names
Jul 21, 2022
8696618
Better docs
Jul 21, 2022
231fb80
fix dealing with errors
Jul 21, 2022
af59029
Merge branch 'main' into issue-771-msg-count
AlekSi Jul 21, 2022
8465bab
Merge branch 'main' into issue-771-msg-count
rumyantseva Jul 22, 2022
805788c
Try to fix codecov reporting
AlekSi Jul 22, 2022
8d6ca4f
better use of error handling
Jul 22, 2022
5f1328f
Merge branch 'issue-771-msg-count' of github.com:rumyantseva/FerretDB…
Jul 22, 2022
6c6d799
Merge branch 'main' into issue-771-msg-count
rumyantseva Jul 22, 2022
5cb4d31
Merge branch 'main' into issue-771-msg-count
rumyantseva Jul 25, 2022
68f6822
Fix fields for MsgCount
Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix dealing with errors
  • Loading branch information
Elena Grahovac committed Jul 21, 2022
commit 231fb803f655de3e204ce6f562d4edb53569c53d
16 changes: 8 additions & 8 deletions internal/handlers/tigris/fetch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ package tigris

import (
"context"
"errors"

tigris "github.com/tigrisdata/tigris-client-go/api/server/v1"
api "github.com/tigrisdata/tigris-client-go/api/server/v1"
"github.com/tigrisdata/tigris-client-go/driver"
"go.uber.org/zap"

Expand All @@ -40,20 +39,21 @@ func (h *Handler) fetch(ctx context.Context, param fetchParam) ([]*types.Documen
db := h.driver.UseDatabase(param.db)

collection, err := db.DescribeCollection(ctx, param.collection)
if err != nil {
var tigErr *tigris.TigrisError
if !errors.As(err, &tigErr) {
return nil, lazyerrors.Error(err)
}
switch err := err.(type) {
case nil:
// do nothing
case *driver.Error:
//nolint:nosnakecase // Tigris named their const that way
if tigErr.Code == tigris.Code_NOT_FOUND {
if err.Code == api.Code_NOT_FOUND {
h.L.Debug(
"Collection doesn't exist, handling a case to deal with a non-existing collection (return empty list)",
zap.String("db", param.db), zap.String("collection", param.collection),
)
return []*types.Document{}, nil
}
return nil, lazyerrors.Error(err)
default:
return nil, lazyerrors.Error(err)
}

var schema tjson.Schema
Expand Down
18 changes: 10 additions & 8 deletions internal/handlers/tigris/msg_drop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ package tigris

import (
"context"
"errors"

tigris "github.com/tigrisdata/tigris-client-go/api/server/v1"
api "github.com/tigrisdata/tigris-client-go/api/server/v1"
"github.com/tigrisdata/tigris-client-go/driver"

"github.com/FerretDB/FerretDB/internal/handlers/common"
"github.com/FerretDB/FerretDB/internal/types"
Expand Down Expand Up @@ -46,16 +46,18 @@ func (h *Handler) MsgDrop(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg, er
return nil, err
}

if err = h.driver.UseDatabase(db).DropCollection(ctx, collection); err != nil {
var tigErr *tigris.TigrisError
if !errors.As(err, &tigErr) {
return nil, lazyerrors.Error(err)
}
err = h.driver.UseDatabase(db).DropCollection(ctx, collection)
switch err := err.(type) {
case nil:
// do nothing
case *driver.Error:
//nolint:nosnakecase // Tigris named their const that way
if tigErr.Code == tigris.Code_NOT_FOUND {
if err.Code == api.Code_NOT_FOUND {
AlekSi marked this conversation as resolved.
Show resolved Hide resolved
return nil, common.NewErrorMsg(common.ErrNamespaceNotFound, "ns not found")
}
return nil, lazyerrors.Error(err)
default:
return nil, lazyerrors.Error(err)
}

var reply wire.OpMsg
Expand Down