Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MsgCount for Tigris #928

Merged
merged 22 commits into from
Jul 26, 2022
Merged

Implement MsgCount for Tigris #928

merged 22 commits into from
Jul 26, 2022

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Jul 21, 2022 •
edited
Loading

Description

This PR closes #771.

The implementation is similar to how MsgCount is implemented for Postgres and how MsgFind is implemented for Tigris.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Jul 21, 2022
@rumyantseva rumyantseva added code/feature Some user-visible feature is not implemented yet code/tigris labels Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #928 (68f6822) into main (3d53f60) will increase coverage by 2.36%.
The diff coverage is 52.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   59.98%   62.35%   +2.36%     
==========================================
  Files         224      225       +1     
  Lines       10346    10444      +98     
==========================================
+ Hits         6206     6512     +306     
+ Misses       3431     3162     -269     
- Partials      709      770      +61
Impacted Files Coverage Δ
internal/handlers/tigris/msg_dropdatabase.go 56.25% <0.00%> (+56.25%) ⬆️
internal/handlers/tigris/msg_count.go 47.14% <46.37%> (+47.14%) ⬆️
internal/handlers/tigris/tigris.go 65.38% <50.00%> (+65.38%) ⬆️
internal/handlers/tigris/msg_drop.go 60.52% <71.42%> (+60.52%) ⬆️
internal/handlers/tigris/fetch.go 66.66% <83.33%> (+66.66%) ⬆️
internal/handlers/pg/pgdb/collections.go 54.86% <0.00%> (-5.31%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/registry/tigris.go 100.00% <0.00%> (ø)
internal/tjson/schema.go 48.68% <0.00%> (+2.63%) ⬆️
internal/handlers/pg/pgdb/databases.go 60.00% <0.00%> (+5.33%) ⬆️
... and 13 more
Flag Coverage Δ
integration 57.28% <52.57%> (-5.23%) ⬇️
mongodb 18.82% <ø> (-0.04%) ⬇️
pg 62.41% <ø> (ø)
tigris 18.31% <52.57%> (-31.44%) ⬇️
unit 24.49% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title [DRAFT] Implement MsgCount for Tigris Implement MsgCount for Tigris Jul 21, 2022
@rumyantseva rumyantseva marked this pull request as ready for review July 21, 2022 13:56
@rumyantseva rumyantseva requested a review from a team as a code owner July 21, 2022 13:56
@rumyantseva rumyantseva requested review from AlekSi, a team, seeforschauer, noisersup and w84thesun and removed request for a team July 21, 2022 13:56
@rumyantseva rumyantseva mentioned this pull request Jul 21, 2022
Closed
@rumyantseva rumyantseva added no ci and removed no ci labels Jul 21, 2022
AlekSi
AlekSi reviewed Jul 22, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/handlers/tigris/msg_drop.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested a review from AlekSi July 22, 2022 14:48
w84thesun
w84thesun previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlekSi
AlekSi requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update command's arguments: #928 (comment)

@AlekSi AlekSi added this to the v0.6.0 milestone Jul 25, 2022
@rumyantseva rumyantseva requested review from AlekSi and w84thesun July 25, 2022 22:09
@AlekSi AlekSi enabled auto-merge (squash) July 26, 2022 05:56
@AlekSi AlekSi mentioned this pull request Jul 26, 2022
Merged
6 tasks
@AlekSi AlekSi merged commit 4446f44 into FerretDB:main Jul 26, 2022
@AlekSi AlekSi modified the milestones: v0.6.0, v0.5.1 Jul 26, 2022
@rumyantseva rumyantseva deleted the issue-771-msg-count branch August 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeforschauer seeforschauer seeforschauer left review comments

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.

Implement MsgCount for Tigris
4 participants
@rumyantseva @AlekSi @w84thesun @seeforschauer