-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fluky test #757
Fix fluky test #757
Conversation
We run a lot of tests in parallel, so the number of collections is in the range between 1 (this test) and many, where "many" is 100 for now.
Codecov Report
@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 65.29% 65.27% -0.02%
==========================================
Files 203 203
Lines 8430 8430
==========================================
- Hits 5504 5503 -1
- Misses 2283 2285 +2
+ Partials 643 642 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks a bit flaky, but let's try. The explanation about 100 makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, ok we a;ready discussed GreaterOrEqual
before..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We run a lot of tests in parallel, so the number of collections is in the range between 1 (this test) and many, where "many" is 100 for now.
Uptime can also be as small as 0 seconds on a fast machine but can also be large if the environment wasn't restarted for a long time.
Checklist
task all
passes.See CONTRIBUTING.md for more details.