Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluky test #757

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Fix fluky test #757

merged 3 commits into from
Jun 21, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 21, 2022

We run a lot of tests in parallel, so the number of collections is in the range between 1 (this test) and many, where "many" is 100 for now.
Uptime can also be as small as 0 seconds on a fast machine but can also be large if the environment wasn't restarted for a long time.

Checklist

  • Tests are added for new functionality or fixed bugs.
  • task all passes.

See CONTRIBUTING.md for more details.

We run a lot of tests in parallel, so the number of collections is in the range between 1 (this test) and many, where "many" is 100 for now.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 21, 2022
@AlekSi AlekSi self-assigned this Jun 21, 2022
@AlekSi AlekSi requested a review from rumyantseva as a code owner June 21, 2022 14:41
@AlekSi
Copy link
Member Author

AlekSi commented Jun 21, 2022

@AlekSi AlekSi requested review from a team, w84thesun and noisersup and removed request for a team June 21, 2022 14:42
@AlekSi AlekSi enabled auto-merge (squash) June 21, 2022 14:42
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #757 (fc3c89f) into main (cf873e8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   65.29%   65.27%   -0.02%     
==========================================
  Files         203      203              
  Lines        8430     8430              
==========================================
- Hits         5504     5503       -1     
- Misses       2283     2285       +2     
+ Partials      643      642       -1     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/pool.go 65.87% <0.00%> (-1.59%) ⬇️
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
Flag Coverage Δ
FerretDB 62.57% <ø> (+0.03%) ⬆️
MongoDB 7.25% <ø> (ø)
integration 62.68% <ø> (+0.03%) ⬆️
unit 25.58% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva previously approved these changes Jun 21, 2022
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks a bit flaky, but let's try. The explanation about 100 makes sense to me.

@AlekSi AlekSi disabled auto-merge June 21, 2022 15:52
@AlekSi AlekSi enabled auto-merge (squash) June 21, 2022 15:54
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, ok we a;ready discussed GreaterOrEqual before..

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit b0a2b4e into FerretDB:main Jun 21, 2022
@AlekSi AlekSi deleted the fix-flaky-test branch June 21, 2022 16:12
@AlekSi AlekSi added this to the v0.3.1 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants